From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 10 Jun 2016 06:08:50 +0200 Subject: [U-Boot] [PATCH v3 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl usb controllers In-Reply-To: References: <1465474911-29297-1-git-send-email-sriram.dash@nxp.com> <1465474911-29297-3-git-send-email-sriram.dash@nxp.com> <57596F8E.30205@denx.de> Message-ID: <575A3D52.1010901@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/10/2016 05:47 AM, Sriram Dash wrote: >> -----Original Message----- >> From: Marek Vasut [mailto:marex at denx.de] >> Sent: Thursday, June 09, 2016 7:01 PM >> To: Sriram Dash ; u-boot at lists.denx.de >> Cc: york sun ; albert.u.boot at aribaud.net; Rajesh Bhagat >> >> Subject: Re: [PATCH v3 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl >> usb controllers Would you please fix your mailer to omit this useless header ? [...] >>> diff --git a/include/fsl_usb.h b/include/fsl_usb.h index >>> 187e384..882a5f5 100644 >>> --- a/include/fsl_usb.h >>> +++ b/include/fsl_usb.h >>> @@ -85,6 +85,12 @@ struct ccsr_usb_phy { #define >>> CONFIG_SYS_FSL_USB_SQUELCH_PROG_MASK 0x07 #endif >>> >>> +/* USB Controllers */ >>> +#define FSL_USB2_MPH "fsl-usb2-mph" >>> +#define FSL_USB2_DR "fsl-usb2-dr" >>> +#define USB2_CI "usb2-ci" What is this "usb2-ci" string ? Is this some DT property or DT compatible property or just some random string? >>> +#define SNPS_DWC3 "snps,dwc3" >> >> Is this needed as a global macro or can it be local to fsl-dt-fixup.c ? >> > > Currently, the macro are only being used for dt fixup for fsl usb. > However, in the near future, they might be needed for some other purpose, > for example, board specific settings. If they will be used for other purpose, then they can be moved. They are local now, so keep them local. > So, i think i will stick with the global macro. > >>> /* USB Erratum Checking code */ >>> #ifdef CONFIG_PPC >>> static inline bool has_dual_phy(void) >>> >> >> >> -- >> Best regards, >> Marek Vasut -- Best regards, Marek Vasut