public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache
@ 2016-06-09 12:09 Paul Burton
  2016-06-09 12:09 ` [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex Paul Burton
  2016-06-10 10:42 ` [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Daniel Schwierzeck
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Burton @ 2016-06-09 12:09 UTC (permalink / raw)
  To: u-boot

Commit fb64cda57998 ("MIPS: Abstract cache op loops with a macro")
accidentally modified invalidate_dcache_range to operate on the L1
Icache instead of the Dcache. Fix the cache op used to operate on the
Dcache.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: fb64cda57998 ("MIPS: Abstract cache op loops with a macro")

---

 arch/mips/lib/cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lib/cache.c b/arch/mips/lib/cache.c
index 5f520c0..db81953 100644
--- a/arch/mips/lib/cache.c
+++ b/arch/mips/lib/cache.c
@@ -91,5 +91,5 @@ void invalidate_dcache_range(ulong start_addr, ulong stop)
 	if (start_addr == stop)
 		return;
 
-	cache_loop(start_addr, stop, lsize, HIT_INVALIDATE_I);
+	cache_loop(start_addr, stop, lsize, HIT_INVALIDATE_D);
 }
-- 
2.8.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex
  2016-06-09 12:09 [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Paul Burton
@ 2016-06-09 12:09 ` Paul Burton
  2016-06-10 10:46   ` Daniel Schwierzeck
  2016-06-10 10:42 ` [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Daniel Schwierzeck
  1 sibling, 1 reply; 4+ messages in thread
From: Paul Burton @ 2016-06-09 12:09 UTC (permalink / raw)
  To: u-boot

For consistency with the other cache-related Kconfig entries & the
values actually set by boards, make CONFIG_SYS_DCACHE_LINE_SIZE an int
entry instead of a hex entry.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: 372286217f05 ("MIPS: Split I & D cache line size config")
---

 arch/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 5c30ae9..21066f0 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -253,7 +253,7 @@ config SYS_DCACHE_SIZE
 	  The total size of the L1 Dcache, if known at compile time.
 
 config SYS_DCACHE_LINE_SIZE
-	hex
+	int
 	default 0
 	help
 	  The size of L1 Dcache lines, if known at compile time.
-- 
2.8.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache
  2016-06-09 12:09 [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Paul Burton
  2016-06-09 12:09 ` [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex Paul Burton
@ 2016-06-10 10:42 ` Daniel Schwierzeck
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Schwierzeck @ 2016-06-10 10:42 UTC (permalink / raw)
  To: u-boot



Am 09.06.2016 um 14:09 schrieb Paul Burton:
> Commit fb64cda57998 ("MIPS: Abstract cache op loops with a macro")
> accidentally modified invalidate_dcache_range to operate on the L1
> Icache instead of the Dcache. Fix the cache op used to operate on the
> Dcache.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Fixes: fb64cda57998 ("MIPS: Abstract cache op loops with a macro")
> 

applied to u-boot-mips, thanks.

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160610/03b5ac28/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex
  2016-06-09 12:09 ` [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex Paul Burton
@ 2016-06-10 10:46   ` Daniel Schwierzeck
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Schwierzeck @ 2016-06-10 10:46 UTC (permalink / raw)
  To: u-boot



Am 09.06.2016 um 14:09 schrieb Paul Burton:
> For consistency with the other cache-related Kconfig entries & the
> values actually set by boards, make CONFIG_SYS_DCACHE_LINE_SIZE an int
> entry instead of a hex entry.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Fixes: 372286217f05 ("MIPS: Split I & D cache line size config")
> ---
> 
>  arch/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied to u-boot-mips, thanks.

BTW: there is a similar patch from Purna [1] but I applied this one
because it contains a "Fixes:" line.

[1] http://patchwork.ozlabs.org/patch/630747/

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160610/81955cf5/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-10 10:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 12:09 [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Paul Burton
2016-06-09 12:09 ` [U-Boot] [PATCH 2/2] MIPS: Make CONFIG_SYS_DCACHE_LINE_SIZE int, not hex Paul Burton
2016-06-10 10:46   ` Daniel Schwierzeck
2016-06-10 10:42 ` [U-Boot] [PATCH 1/2] MIPS: Fix invalidate_dcache_range to operate on L1 Dcache Daniel Schwierzeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox