public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] libfdt: Add option to disable arch_fixup_fdt() calls
Date: Fri, 10 Jun 2016 13:07:42 +0200	[thread overview]
Message-ID: <575A9F7E.30405@xilinx.com> (raw)
In-Reply-To: <57597FE5.6060407@suse.de>

On 9.6.2016 16:40, Alexander Graf wrote:
> On 06/09/2016 04:32 PM, Michal Simek wrote:
>> On 9.6.2016 16:29, Alexander Graf wrote:
>>> On 06/09/2016 04:23 PM, Michal Simek wrote:
>>>> Disable arch_fixup_fdt() calls for cases where U-Boot shouldn't update
>>>> memory setup in DTB file.
>>>> One example of usage of this option is to boot OS with different memory
>>>> setup than U-Boot use.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> Could we instead just have the board file provide a fixup? It could then
>>> also fix up the efi memory map.
>> Not sure what exactly you are asking for.
>> Do you mean to add fixup function to board file and overwrite default
>> one?
> 
> You have to touch some other code anyway to make this work with a
> particular board, right? In that case, you can as well add a function to
> the board file that explicitly provides a different, known good memory map.

I cant' see the reason to touch particular board. In past AMP solution
where one core use the part of memory and second another part was the
reason I needed this.
For ARM64 case as you know from arm IRC I was trying to boot Linux from
memory above 32bit space and for these tests I need to convince u-boot
not to touch dtb memory setup.

But for the same board I want to use standard behavior but for some case
this needs to be enabled.

> 
> Can you have a weaker overload? Basically I would like to have a board
> provide arch_fixup_fdt() which would override the one in bootm-fdt.c.
> But we can also rename arch_fixup_fdt() in bootm-fdt.c to
> board_fixup_fdt() function, declare it weak and have arch_fixup_fdt()
> call that.

arch_fixup_fdt is already weaker function in image-fdt.c and ARM and
MIPS define it.

I don't think that renaming solve anything. This patch is really just
ON/OFF switch of fixup behavior.

Thanks,
Michal

  reply	other threads:[~2016-06-10 11:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 14:23 [U-Boot] [PATCH] libfdt: Add option to disable arch_fixup_fdt() calls Michal Simek
2016-06-09 14:29 ` Alexander Graf
2016-06-09 14:32   ` Michal Simek
2016-06-09 14:40     ` Alexander Graf
2016-06-10 11:07       ` Michal Simek [this message]
2016-06-10 11:13         ` Alexander Graf
2016-06-10 11:51           ` Michal Simek
2016-06-10 12:12             ` Alexander Graf
2016-06-10 12:31               ` Michal Simek
2016-06-10 12:34                 ` Alexander Graf
2016-06-10 16:44 ` Simon Glass
2016-07-15  7:36   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575A9F7E.30405@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox