From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: rk3288: Change method of loading u-boot
Date: Sun, 12 Jun 2016 13:50:31 +0800 [thread overview]
Message-ID: <575CF827.3050104@rock-chips.com> (raw)
In-Reply-To: <CAEYML7Ks4DKsdJZGYM9xMkMezYA8M2iq0vtvey1EbDKw6UU8fw@mail.gmail.com>
On 2016?06?12? 13:46, Eddie Cai wrote:
> Why not move arch/arm/mach-rockchip/rk3036/save_boot_param.S to
> arch/arm/mach-rockchip/save_boot_param.S. Then use it directly?
>
> 2016-06-12 12:29 GMT+08:00 Eddie Cai <eddie.cai@rock-chips.com>:
Okay, it's make sense to me.
>> Hi
>>
>> 2016-06-12 11:56 GMT+08:00 Ziyuan Xu <xzy.xu@rock-chips.com>:
>>> If we would like to boot from SD card, we have to implement mmc driver
>>> in SPL stage, and get a slightly larger spl binrary. RK3288's bootrom
>>> code has the ability to load spl and u-boot. This patch tasks maskrom to
>>> load u-boot.
>>>
>>> Loading sequence after rework:
>>> bootrom ==> spl ==> bootrom ==> u-boot
>>>
>>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>> ---
>>> arch/arm/mach-rockchip/rk3288/save_boot_param.S | 32 +++++++++++++++++++++++++
>>> 1 file changed, 32 insertions(+)
>>> create mode 100644 arch/arm/mach-rockchip/rk3288/save_boot_param.S
>>>
>>> diff --git a/arch/arm/mach-rockchip/rk3288/save_boot_param.S b/arch/arm/mach-rockchip/rk3288/save_boot_param.S
>>> new file mode 100644
>>> index 0000000..778ec83
>>> --- /dev/null
>>> +++ b/arch/arm/mach-rockchip/rk3288/save_boot_param.S
>>> @@ -0,0 +1,32 @@
>>> +/*
>>> + * (C) Copyright 2015 Google, Inc
>> Should be "Copyright 2016 Rockchip Electronics Co., Ltd"
Fix it next patch.
BTW, I'm sorry that I forget to add other changes, please ignore this
patch, I will re-send other one.
>>> + *
>>> + * SPDX-License-Identifier: GPL-2.0+
>>> + */
>>> +
>>> +#include <linux/linkage.h>
>>> +
>>> +.globl SAVE_SP_ADDR
>>> +SAVE_SP_ADDR:
>>> + .word 0
>>> +
>>> +/*
>>> + * void save_boot_params
>>> + *
>>> + * Save sp, lr, r1~r12
>>> + */
>>> +ENTRY(save_boot_params)
>>> + push {r1-r12, lr}
>>> + ldr r0, =SAVE_SP_ADDR
>>> + str sp, [r0]
>>> + b save_boot_params_ret @ back to my caller
>>> +ENDPROC(save_boot_params)
>>> +
>>> +
>>> +.globl back_to_bootrom
>>> +ENTRY(back_to_bootrom)
>>> + ldr r0, =SAVE_SP_ADDR
>>> + ldr sp, [r0]
>>> + mov r0, #0
>>> + pop {r1-r12, pc}
>>> +ENDPROC(back_to_bootrom)
>>> --
>>> 1.9.1
>>>
>>>
>>>
>>
>>
>> --
>> Eddie
>
>
>
next prev parent reply other threads:[~2016-06-12 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 5:46 [U-Boot] [PATCH] rockchip: rk3288: Change method of loading u-boot Eddie Cai
2016-06-12 5:50 ` Ziyuan Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-12 3:56 Ziyuan Xu
2016-06-12 4:29 ` Eddie Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575CF827.3050104@rock-chips.com \
--to=xzy.xu@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox