public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] configs: Fixup afet BOOTDELAY migration
Date: Mon, 13 Jun 2016 07:36:08 +0200	[thread overview]
Message-ID: <575E4648.4060600@denx.de> (raw)
In-Reply-To: <599d996b-d6d3-29b3-70b0-51ea4727b8dc@redhat.com>

Hello Hans,

Am 11.06.2016 um 13:36 schrieb Hans de Goede:
> Hi,
>
> On 10-06-16 21:43, Tom Rini wrote:
>> A number of config files were not correctly migrated for BOOTDELAY moving
>> over to Kconfig.  Update these configs which were not done correctly.
>>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> ---
>> Changes in v2:
>> - I regenerated this after locally applying (and throwing away as there will
>>   be an updated series) fixes to moveconfig.py.  This means we now catch the
>>   boards that were doing -1 as a value and 1 as a value.  I've also dropped
>>   the parts that removed empty #if/#endif things as we can do that outside
>>   of this patch.
>
> NACK, see the reply I just send to the similar patch from Masahiro which
> was send earlier today, which is currently sitting in the moderation
> list due to it having 101 people in the Cc.
>
> Note the fact that this touches files which are maintained by 101 people
> alone should be a big red flag that this is a very very bad idea.

How should we move to Kconfig else? Common options touch a lot of
boards ...

> Please just revert the patch causing all this pain and lets get back
> to the drawing board on this, or on how we move things to Kconfig
> in general.

Sorry for all the trouble with this patch. Reverting seems the best
way currently.

@Tom: What do you think?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2016-06-13  5:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 15:19 [U-Boot] [PATCH] configs: Fixup after BOOTDELAY migration Tom Rini
2016-06-10 15:29 ` Masahiro Yamada
2016-06-10 19:43 ` [U-Boot] [PATCH v2] configs: Fixup afet " Tom Rini
2016-06-11 11:36   ` Hans de Goede
2016-06-13  5:36     ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575E4648.4060600@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox