From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 13 Jun 2016 07:36:08 +0200 Subject: [U-Boot] [PATCH v2] configs: Fixup afet BOOTDELAY migration In-Reply-To: <599d996b-d6d3-29b3-70b0-51ea4727b8dc@redhat.com> References: <1465571974-2468-1-git-send-email-trini@konsulko.com> <1465587804-25575-1-git-send-email-trini@konsulko.com> <599d996b-d6d3-29b3-70b0-51ea4727b8dc@redhat.com> Message-ID: <575E4648.4060600@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Hans, Am 11.06.2016 um 13:36 schrieb Hans de Goede: > Hi, > > On 10-06-16 21:43, Tom Rini wrote: >> A number of config files were not correctly migrated for BOOTDELAY moving >> over to Kconfig. Update these configs which were not done correctly. >> >> Signed-off-by: Tom Rini >> --- >> Changes in v2: >> - I regenerated this after locally applying (and throwing away as there will >> be an updated series) fixes to moveconfig.py. This means we now catch the >> boards that were doing -1 as a value and 1 as a value. I've also dropped >> the parts that removed empty #if/#endif things as we can do that outside >> of this patch. > > NACK, see the reply I just send to the similar patch from Masahiro which > was send earlier today, which is currently sitting in the moderation > list due to it having 101 people in the Cc. > > Note the fact that this touches files which are maintained by 101 people > alone should be a big red flag that this is a very very bad idea. How should we move to Kconfig else? Common options touch a lot of boards ... > Please just revert the patch causing all this pain and lets get back > to the drawing board on this, or on how we move things to Kconfig > in general. Sorry for all the trouble with this patch. Reverting seems the best way currently. @Tom: What do you think? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany