* [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART
@ 2016-06-15 4:33 Bin Meng
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Bin Meng @ 2016-06-15 4:33 UTC (permalink / raw)
To: u-boot
There are quite a number of BayTrail boards that uses an external
SuperIO chipset to provide the legacy UART. For such cases, it's
better to have a Kconfig option to enable the internal UART.
So far BayleyBay and MinnowMax boards are using internal UART as
the U-Boot console, enable this on these two boards.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
configs/bayleybay_defconfig | 1 +
configs/minnowmax_defconfig | 1 +
3 files changed, 13 insertions(+)
diff --git a/arch/x86/cpu/baytrail/Kconfig b/arch/x86/cpu/baytrail/Kconfig
index 407feb2..1c8ac37 100644
--- a/arch/x86/cpu/baytrail/Kconfig
+++ b/arch/x86/cpu/baytrail/Kconfig
@@ -7,3 +7,14 @@
config INTEL_BAYTRAIL
bool
select HAVE_FSP if !EFI
+
+if INTEL_BAYTRAIL
+config INTERNAL_UART
+ bool "Enable the SoC integrated legacy UART"
+ help
+ There is a legacy UART integrated into the Bay Trail SoC.
+ A maximum baud rate of 115200 bps is supported. For this
+ reason, it is recommended that the UART port be used for
+ debug purposes only, eg: U-Boot console.
+
+endif
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 9f1d7fb..0a71bb8 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -2,6 +2,7 @@ CONFIG_X86=y
CONFIG_VENDOR_INTEL=y
CONFIG_DEFAULT_DEVICE_TREE="bayleybay"
CONFIG_TARGET_BAYLEYBAY=y
+CONFIG_INTERNAL_UART=y
CONFIG_HAVE_INTEL_ME=y
CONFIG_ENABLE_MRC_CACHE=y
CONFIG_SMP=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 28b837d..ba2b7dc 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -2,6 +2,7 @@ CONFIG_X86=y
CONFIG_VENDOR_INTEL=y
CONFIG_DEFAULT_DEVICE_TREE="minnowmax"
CONFIG_TARGET_MINNOWMAX=y
+CONFIG_INTERNAL_UART=y
CONFIG_HAVE_INTEL_ME=y
CONFIG_ENABLE_MRC_CACHE=y
CONFIG_SMP=y
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART
2016-06-15 4:33 [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Bin Meng
@ 2016-06-15 4:33 ` Bin Meng
2016-06-15 12:14 ` Stefan Roese
2016-06-17 3:51 ` Simon Glass
2016-06-15 12:14 ` [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Stefan Roese
2016-06-17 3:51 ` Simon Glass
2 siblings, 2 replies; 8+ messages in thread
From: Bin Meng @ 2016-06-15 4:33 UTC (permalink / raw)
To: u-boot
For any FSP enabled boards that want to enable debug UART support,
setup_internal_uart() will be called, but this API is only available
on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/lib/fsp/fsp_support.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c
index b05dced..a480361 100644
--- a/arch/x86/lib/fsp/fsp_support.c
+++ b/arch/x86/lib/fsp/fsp_support.c
@@ -110,7 +110,7 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf)
struct upd_region *fsp_upd;
#endif
-#ifdef CONFIG_DEBUG_UART
+#ifdef CONFIG_INTERNAL_UART
setup_internal_uart(1);
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
@ 2016-06-15 12:14 ` Stefan Roese
2016-06-17 3:51 ` Simon Glass
1 sibling, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2016-06-15 12:14 UTC (permalink / raw)
To: u-boot
On 15.06.2016 06:33, Bin Meng wrote:
> For any FSP enabled boards that want to enable debug UART support,
> setup_internal_uart() will be called, but this API is only available
> on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
2016-06-15 12:14 ` Stefan Roese
@ 2016-06-17 3:51 ` Simon Glass
2016-06-17 4:42 ` Bin Meng
1 sibling, 1 reply; 8+ messages in thread
From: Simon Glass @ 2016-06-17 3:51 UTC (permalink / raw)
To: u-boot
On 14 June 2016 at 22:33, Bin Meng <bmeng.cn@gmail.com> wrote:
> For any FSP enabled boards that want to enable debug UART support,
> setup_internal_uart() will be called, but this API is only available
> on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/x86/lib/fsp/fsp_support.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
nit: FSP-enabled
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART
2016-06-17 3:51 ` Simon Glass
@ 2016-06-17 4:42 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2016-06-17 4:42 UTC (permalink / raw)
To: u-boot
On Fri, Jun 17, 2016 at 11:51 AM, Simon Glass <sjg@chromium.org> wrote:
> On 14 June 2016 at 22:33, Bin Meng <bmeng.cn@gmail.com> wrote:
>> For any FSP enabled boards that want to enable debug UART support,
>> setup_internal_uart() will be called, but this API is only available
>> on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> arch/x86/lib/fsp/fsp_support.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> nit: FSP-enabled
>
Fixed the nits, and
> Reviewed-by: Simon Glass <sjg@chromium.org>
applied to u-boot-x86/next, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART
2016-06-15 4:33 [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Bin Meng
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
@ 2016-06-15 12:14 ` Stefan Roese
2016-06-17 3:51 ` Simon Glass
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2016-06-15 12:14 UTC (permalink / raw)
To: u-boot
On 15.06.2016 06:33, Bin Meng wrote:
> There are quite a number of BayTrail boards that uses an external
> SuperIO chipset to provide the legacy UART. For such cases, it's
> better to have a Kconfig option to enable the internal UART.
>
> So far BayleyBay and MinnowMax boards are using internal UART as
> the U-Boot console, enable this on these two boards.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART
2016-06-15 4:33 [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Bin Meng
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
2016-06-15 12:14 ` [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Stefan Roese
@ 2016-06-17 3:51 ` Simon Glass
2016-06-17 4:42 ` Bin Meng
2 siblings, 1 reply; 8+ messages in thread
From: Simon Glass @ 2016-06-17 3:51 UTC (permalink / raw)
To: u-boot
On 14 June 2016 at 22:33, Bin Meng <bmeng.cn@gmail.com> wrote:
> There are quite a number of BayTrail boards that uses an external
> SuperIO chipset to provide the legacy UART. For such cases, it's
> better to have a Kconfig option to enable the internal UART.
>
> So far BayleyBay and MinnowMax boards are using internal UART as
> the U-Boot console, enable this on these two boards.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
> configs/bayleybay_defconfig | 1 +
> configs/minnowmax_defconfig | 1 +
> 3 files changed, 13 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART
2016-06-17 3:51 ` Simon Glass
@ 2016-06-17 4:42 ` Bin Meng
0 siblings, 0 replies; 8+ messages in thread
From: Bin Meng @ 2016-06-17 4:42 UTC (permalink / raw)
To: u-boot
On Fri, Jun 17, 2016 at 11:51 AM, Simon Glass <sjg@chromium.org> wrote:
> On 14 June 2016 at 22:33, Bin Meng <bmeng.cn@gmail.com> wrote:
>> There are quite a number of BayTrail boards that uses an external
>> SuperIO chipset to provide the legacy UART. For such cases, it's
>> better to have a Kconfig option to enable the internal UART.
>>
>> So far BayleyBay and MinnowMax boards are using internal UART as
>> the U-Boot console, enable this on these two boards.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
>> configs/bayleybay_defconfig | 1 +
>> configs/minnowmax_defconfig | 1 +
>> 3 files changed, 13 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
applied to u-boot-x86/next, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-17 4:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-15 4:33 [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Bin Meng
2016-06-15 4:33 ` [U-Boot] [PATCH 2/2] x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART Bin Meng
2016-06-15 12:14 ` Stefan Roese
2016-06-17 3:51 ` Simon Glass
2016-06-17 4:42 ` Bin Meng
2016-06-15 12:14 ` [U-Boot] [PATCH 1/2] x86: baytrail: Introduce a Kconfig option for the internal UART Stefan Roese
2016-06-17 3:51 ` Simon Glass
2016-06-17 4:42 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox