* [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite
@ 2016-06-16 12:02 Christopher Spinrath
2016-06-16 12:48 ` Igor Grinberg
2016-06-18 8:46 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Christopher Spinrath @ 2016-06-16 12:02 UTC (permalink / raw)
To: u-boot
Old revisions of Utilite (based on cm-fx6) do not have a dedicated
card detect pin. But the card is removable by the user and card
detection can be realized with polling (e.g. supported by Linux).
Add the broken-cd property to the mmc device tree instead of the
non-removable property to make card detection possible if polling
is supported.
Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
---
Notes:
Changes since v1:
- remove Fixes: tag
- add Nikita's Acked-By
board/compulab/cm_fx6/cm_fx6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
index a21e7b0..712057a 100644
--- a/board/compulab/cm_fx6/cm_fx6.c
+++ b/board/compulab/cm_fx6/cm_fx6.c
@@ -610,7 +610,7 @@ int ft_board_setup(void *blob, bd_t *bd)
fdt_shrink_to_minimum(blob); /* Make room for new properties */
nodeoffset = fdt_path_offset(blob, USDHC3_PATH);
fdt_delprop(blob, nodeoffset, "cd-gpios");
- fdt_find_and_setprop(blob, USDHC3_PATH, "non-removable",
+ fdt_find_and_setprop(blob, USDHC3_PATH, "broken-cd",
NULL, 0, 1);
fdt_find_and_setprop(blob, USDHC3_PATH, "keep-power-in-suspend",
NULL, 0, 1);
--
2.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite
2016-06-16 12:02 [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite Christopher Spinrath
@ 2016-06-16 12:48 ` Igor Grinberg
2016-06-18 8:46 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Igor Grinberg @ 2016-06-16 12:48 UTC (permalink / raw)
To: u-boot
On 06/16/2016 03:02 PM, Christopher Spinrath wrote:
> Old revisions of Utilite (based on cm-fx6) do not have a dedicated
> card detect pin. But the card is removable by the user and card
> detection can be realized with polling (e.g. supported by Linux).
>
> Add the broken-cd property to the mmc device tree instead of the
> non-removable property to make card detection possible if polling
> is supported.
>
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite
2016-06-16 12:02 [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite Christopher Spinrath
2016-06-16 12:48 ` Igor Grinberg
@ 2016-06-18 8:46 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2016-06-18 8:46 UTC (permalink / raw)
To: u-boot
On 16/06/2016 14:02, Christopher Spinrath wrote:
> Old revisions of Utilite (based on cm-fx6) do not have a dedicated
> card detect pin. But the card is removable by the user and card
> detection can be realized with polling (e.g. supported by Linux).
>
> Add the broken-cd property to the mmc device tree instead of the
> non-removable property to make card detection possible if polling
> is supported.
>
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
> ---
Applied to master (bug fix), thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-18 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-16 12:02 [U-Boot] [PATCH v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite Christopher Spinrath
2016-06-16 12:48 ` Igor Grinberg
2016-06-18 8:46 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox