[U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives

[U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives

[Marek Vasut]

Repair typos in the previous "arm: lib: fix push/pop-section directives"
patch, which prevented VCMA9 board from building.

Signed-off-by: Marek Vasut <marex@denx.de>
Fixes: b2f1858455e9 ("arm: lib: fix push/pop-section directives")
Cc: Tom Warren <twarren@nvidia.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/lib/lib1funcs.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/lib/lib1funcs.S b/arch/arm/lib/lib1funcs.S
index 9bf93ce..76968ce 100644
--- a/arch/arm/lib/lib1funcs.S
+++ b/arch/arm/lib/lib1funcs.S
@@ -367,9 +367,9 @@ UNWIND(.fnend)
 ENDPROC(Ldiv0)
 .popsection
 
-.pushsection .text.__gnu_thumb1_case_sqi, "ax"
 /* Thumb-1 specialities */
 #if defined(CONFIG_SYS_THUMB_BUILD) && !defined(CONFIG_HAS_THUMB2)
+.pushsection .text.__gnu_thumb1_case_sqi, "ax"
 ENTRY(__gnu_thumb1_case_sqi)
 	push	{r1}
 	mov	r1, lr
@@ -383,7 +383,7 @@ ENTRY(__gnu_thumb1_case_sqi)
 ENDPROC(__gnu_thumb1_case_sqi)
 .popsection
 
-_.pushsection .text.__gnu_thumb1_case_uqi, "ax"
+.pushsection .text.__gnu_thumb1_case_uqi, "ax"
 ENTRY(__gnu_thumb1_case_uqi)
 	push	{r1}
 	mov	r1, lr
-- 
2.7.0

[U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives

[Heiko Schocher]

Hello Marek,

Am 05.06.2016 um 00:46 schrieb Marek Vasut:
> Repair typos in the previous "arm: lib: fix push/pop-section directives"
> patch, which prevented VCMA9 board from building.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Fixes: b2f1858455e9 ("arm: lib: fix push/pop-section directives")
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
>   arch/arm/lib/lib1funcs.S | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Thanks! Fixes compile problems on on the axm, taurus boards.
Tested current mainline on them with this fix:

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/lib/lib1funcs.S b/arch/arm/lib/lib1funcs.S
> index 9bf93ce..76968ce 100644
> --- a/arch/arm/lib/lib1funcs.S
> +++ b/arch/arm/lib/lib1funcs.S
> @@ -367,9 +367,9 @@ UNWIND(.fnend)
>   ENDPROC(Ldiv0)
>   .popsection
>
> -.pushsection .text.__gnu_thumb1_case_sqi, "ax"
>   /* Thumb-1 specialities */
>   #if defined(CONFIG_SYS_THUMB_BUILD) && !defined(CONFIG_HAS_THUMB2)
> +.pushsection .text.__gnu_thumb1_case_sqi, "ax"
>   ENTRY(__gnu_thumb1_case_sqi)
>   	push	{r1}
>   	mov	r1, lr
> @@ -383,7 +383,7 @@ ENTRY(__gnu_thumb1_case_sqi)
>   ENDPROC(__gnu_thumb1_case_sqi)
>   .popsection
>
> -_.pushsection .text.__gnu_thumb1_case_uqi, "ax"
> +.pushsection .text.__gnu_thumb1_case_uqi, "ax"
>   ENTRY(__gnu_thumb1_case_uqi)
>   	push	{r1}
>   	mov	r1, lr
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives

[Stephen Warren]

On 06/04/2016 04:46 PM, Marek Vasut wrote:
> Repair typos in the previous "arm: lib: fix push/pop-section directives"
> patch, which prevented VCMA9 board from building.

Reviewed-by: Stephen Warren <swarren@nvidia.com>

Oops, I evidently didn't re-run buildman on enough boards after I fixed 
up some other typos:-(