* [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
@ 2016-06-06 13:11 Guillaume GARDET
2016-06-07 15:56 ` Joe Hershberger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Guillaume GARDET @ 2016-06-06 13:11 UTC (permalink / raw)
To: u-boot
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Cc: joe.hershberger at ni.com
---
net/nfs.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/net/nfs.c b/net/nfs.c
index 78968d8..0ed47c9 100644
--- a/net/nfs.c
+++ b/net/nfs.c
@@ -481,8 +481,22 @@ static int nfs_lookup_reply(uchar *pkt, unsigned len)
if (rpc_pkt.u.reply.rstatus ||
rpc_pkt.u.reply.verifier ||
rpc_pkt.u.reply.astatus ||
- rpc_pkt.u.reply.data[0])
+ rpc_pkt.u.reply.data[0]){
+ switch(ntohl(rpc_pkt.u.reply.astatus)){
+ case 0: /* Not an error */
+ break;
+ case 2: /* Remote can't support NFS version */
+ printf("*** ERROR: NFS version not supported: Requested: V%d, accepted: min V%d - max V%d\n",
+ 2,
+ ntohl(rpc_pkt.u.reply.data[0]),
+ ntohl(rpc_pkt.u.reply.data[1]));
+ break;
+ default: /* Unknown error on 'accept state' flag */
+ printf("*** ERROR: accept state error (%d)\n", ntohl(rpc_pkt.u.reply.astatus));
+ break;
+ }
return -1;
+ }
memcpy(filefh, rpc_pkt.u.reply.data + 1, NFS_FHSIZE);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
2016-06-06 13:11 [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server Guillaume GARDET
@ 2016-06-07 15:56 ` Joe Hershberger
2016-06-17 12:27 ` Guillaume Gardet
2016-06-17 16:28 ` Joe Hershberger
2016-06-21 22:10 ` [U-Boot] " Joe Hershberger
2 siblings, 1 reply; 6+ messages in thread
From: Joe Hershberger @ 2016-06-07 15:56 UTC (permalink / raw)
To: u-boot
On Mon, Jun 6, 2016 at 8:11 AM, Guillaume GARDET
<guillaume.gardet@free.fr> wrote:
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: joe.hershberger at ni.com
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
2016-06-07 15:56 ` Joe Hershberger
@ 2016-06-17 12:27 ` Guillaume Gardet
2016-06-17 15:56 ` Joe Hershberger
0 siblings, 1 reply; 6+ messages in thread
From: Guillaume Gardet @ 2016-06-17 12:27 UTC (permalink / raw)
To: u-boot
Le 07/06/2016 17:56, Joe Hershberger a ?crit :
> On Mon, Jun 6, 2016 at 8:11 AM, Guillaume GARDET
> <guillaume.gardet@free.fr> wrote:
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>> Cc: joe.hershberger at ni.com
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
Joe, you will add it to u-boot-net repo and then send a pull request to Tom or Tom will directly pick it up?
Guillaume
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
2016-06-17 12:27 ` Guillaume Gardet
@ 2016-06-17 15:56 ` Joe Hershberger
0 siblings, 0 replies; 6+ messages in thread
From: Joe Hershberger @ 2016-06-17 15:56 UTC (permalink / raw)
To: u-boot
On Fri, Jun 17, 2016 at 7:27 AM, Guillaume Gardet
<guillaume.gardet@free.fr> wrote:
>
>
> Le 07/06/2016 17:56, Joe Hershberger a ?crit :
>>
>> On Mon, Jun 6, 2016 at 8:11 AM, Guillaume GARDET
>> <guillaume.gardet@free.fr> wrote:
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>> Cc: joe.hershberger at ni.com
>>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>
>
> Joe, you will add it to u-boot-net repo and then send a pull request to Tom
> or Tom will directly pick it up?
I'll take tare of it.
-Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
2016-06-06 13:11 [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server Guillaume GARDET
2016-06-07 15:56 ` Joe Hershberger
@ 2016-06-17 16:28 ` Joe Hershberger
2016-06-21 22:10 ` [U-Boot] " Joe Hershberger
2 siblings, 0 replies; 6+ messages in thread
From: Joe Hershberger @ 2016-06-17 16:28 UTC (permalink / raw)
To: u-boot
Hi Guillaume,
On Mon, Jun 6, 2016 at 8:11 AM, Guillaume GARDET
<guillaume.gardet@free.fr> wrote:
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: joe.hershberger at ni.com
>
> ---
> net/nfs.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/net/nfs.c b/net/nfs.c
> index 78968d8..0ed47c9 100644
> --- a/net/nfs.c
> +++ b/net/nfs.c
> @@ -481,8 +481,22 @@ static int nfs_lookup_reply(uchar *pkt, unsigned len)
> if (rpc_pkt.u.reply.rstatus ||
> rpc_pkt.u.reply.verifier ||
> rpc_pkt.u.reply.astatus ||
> - rpc_pkt.u.reply.data[0])
> + rpc_pkt.u.reply.data[0]){
> + switch(ntohl(rpc_pkt.u.reply.astatus)){
There are 7 checkpatch.pl issues with this patch. I'll fix them when I
apply it, but in the future, please at least run checkpatch and follow
the coding conventions. Even better would be to use tools/patman.
...
-Joe
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server
2016-06-06 13:11 [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server Guillaume GARDET
2016-06-07 15:56 ` Joe Hershberger
2016-06-17 16:28 ` Joe Hershberger
@ 2016-06-21 22:10 ` Joe Hershberger
2 siblings, 0 replies; 6+ messages in thread
From: Joe Hershberger @ 2016-06-21 22:10 UTC (permalink / raw)
To: u-boot
Hi Guillaume,
https://patchwork.ozlabs.org/patch/630898/ was applied to u-boot-net.git.
Thanks!
-Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-21 22:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-06 13:11 [U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server Guillaume GARDET
2016-06-07 15:56 ` Joe Hershberger
2016-06-17 12:27 ` Guillaume Gardet
2016-06-17 15:56 ` Joe Hershberger
2016-06-17 16:28 ` Joe Hershberger
2016-06-21 22:10 ` [U-Boot] " Joe Hershberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox