From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] SPL: fat: Fix spl_parse_image_header() return value handling
Date: Fri, 17 Jun 2016 17:06:05 +0200 [thread overview]
Message-ID: <576411DD.5040108@denx.de> (raw)
In-Reply-To: <CAOMZO5DTtPogQmURS+k8E4rOiELotd1xVGA+JSodPjgU5NiRgA@mail.gmail.com>
On 06/17/2016 05:01 PM, Fabio Estevam wrote:
> Hi Tom,
>
> On Mon, May 23, 2016 at 7:14 PM, Tom Rini <trini@konsulko.com> wrote:
>> On Fri, May 20, 2016 at 01:45:24AM +0200, Marek Vasut wrote:
>>
>>> The spl_parse_image_header() can return 0 and it is not an error.
>>> Only treat non-zero return value as an error.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>>> Cc: Peng Fan <van.freenix@gmail.com>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>> Reviewed-by: Peng Fan <van.freenix@gmail.com>
>>> Reviewed-by: Stefano Babic <sbabic@denx.de>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> Applied to u-boot/master, thanks!
>
> Looks like something went wrong while applying this patch as Marek's
> authorship got lost:
Ah, you're right, nice catch :)
Tom, I don't really care, bug is fixed, you can leave it as it is.
> commit d550e82e4efebf5995809e38e8fb029b8fe6e861
> Author: Tom Rini <trini@konsulko.com>
> Date: Mon May 23 11:51:13 2016 -0400
>
> SPL: fat: Fix spl_parse_image_header() return value handling
>
> The spl_parse_image_header() can return 0 and it is not an error.
> Only treat non-zero return value as an error.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Reviewed-by: Peng Fan <van.freenix@gmail.com>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-06-17 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 23:45 [U-Boot] [PATCH] SPL: fat: Fix spl_parse_image_header() return value handling Marek Vasut
2016-05-20 0:11 ` Fabio Estevam
2016-05-20 9:31 ` Peng Fan
2016-05-20 9:36 ` Stefano Babic
2016-05-20 13:02 ` Tom Rini
2016-05-23 12:14 ` [U-Boot] " Heiko Schocher
2016-05-23 22:14 ` Tom Rini
2016-06-17 15:01 ` Fabio Estevam
2016-06-17 15:06 ` Marek Vasut [this message]
2016-06-19 13:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576411DD.5040108@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox