* [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs
@ 2016-06-20 1:43 Peng Fan
2016-06-20 1:43 ` [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection Peng Fan
2016-06-20 13:58 ` [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Marek Vasut
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2016-06-20 1:43 UTC (permalink / raw)
To: u-boot
There is a 4 bytes hole between phy_cfg2 and phy_status, fix the
usbnc_regs structure to include the hole.
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Split from V1 to a single patch.
drivers/usb/host/ehci-mx6.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index bb48d0d..cc3b11c 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -194,8 +194,9 @@ struct usbnc_regs {
u32 reserve1[10];
u32 phy_cfg1;
u32 phy_cfg2;
+ u32 reserve2;
u32 phy_status;
- u32 reserve2[4];
+ u32 reserve3[4];
u32 adp_cfg1;
u32 adp_cfg2;
u32 adp_status;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection
2016-06-20 1:43 [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Peng Fan
@ 2016-06-20 1:43 ` Peng Fan
2016-06-20 13:58 ` Marek Vasut
2016-06-20 13:58 ` [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2016-06-20 1:43 UTC (permalink / raw)
To: u-boot
The USBNC_PHYCFG2_ACAENB bit should be cleared to enable the
OTG ID detection, not set it. When the bit is set, the ACA
Resistance Detection is enabled, which disables the OTG ID
detection, because the internal pull up is off.
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
split from V1 to a single patch.
drivers/usb/host/ehci-mx6.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index cc3b11c..069f116 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -208,8 +208,11 @@ static void usb_power_config(int index)
(0x10000 * index) + USBNC_OFFSET);
void __iomem *phy_cfg2 = (void __iomem *)(&usbnc->phy_cfg2);
- /* Enable usb_otg_id detection */
- setbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
+ /*
+ * Clear the ACAENB to enable usb_otg_id detection,
+ * otherwise it is the ACA detection enabled.
+ */
+ clrbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
}
int usb_phy_mode(int port)
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection
2016-06-20 1:43 ` [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection Peng Fan
@ 2016-06-20 13:58 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2016-06-20 13:58 UTC (permalink / raw)
To: u-boot
On 06/20/2016 03:43 AM, Peng Fan wrote:
> The USBNC_PHYCFG2_ACAENB bit should be cleared to enable the
> OTG ID detection, not set it. When the bit is set, the ACA
> Resistance Detection is enabled, which disables the OTG ID
> detection, because the internal pull up is off.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied, thanks
> V2:
> split from V1 to a single patch.
>
> drivers/usb/host/ehci-mx6.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index cc3b11c..069f116 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -208,8 +208,11 @@ static void usb_power_config(int index)
> (0x10000 * index) + USBNC_OFFSET);
> void __iomem *phy_cfg2 = (void __iomem *)(&usbnc->phy_cfg2);
>
> - /* Enable usb_otg_id detection */
> - setbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
> + /*
> + * Clear the ACAENB to enable usb_otg_id detection,
> + * otherwise it is the ACA detection enabled.
> + */
> + clrbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
> }
>
> int usb_phy_mode(int port)
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs
2016-06-20 1:43 [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Peng Fan
2016-06-20 1:43 ` [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection Peng Fan
@ 2016-06-20 13:58 ` Marek Vasut
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2016-06-20 13:58 UTC (permalink / raw)
To: u-boot
On 06/20/2016 03:43 AM, Peng Fan wrote:
> There is a 4 bytes hole between phy_cfg2 and phy_status, fix the
> usbnc_regs structure to include the hole.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied, thanks
> V2:
> Split from V1 to a single patch.
>
> drivers/usb/host/ehci-mx6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index bb48d0d..cc3b11c 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -194,8 +194,9 @@ struct usbnc_regs {
> u32 reserve1[10];
> u32 phy_cfg1;
> u32 phy_cfg2;
> + u32 reserve2;
> u32 phy_status;
> - u32 reserve2[4];
> + u32 reserve3[4];
> u32 adp_cfg1;
> u32 adp_cfg2;
> u32 adp_status;
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-20 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-20 1:43 [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Peng Fan
2016-06-20 1:43 ` [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection Peng Fan
2016-06-20 13:58 ` Marek Vasut
2016-06-20 13:58 ` [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox