public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection
Date: Mon, 20 Jun 2016 15:58:11 +0200	[thread overview]
Message-ID: <5767F673.2000101@denx.de> (raw)
In-Reply-To: <1466386989-1366-2-git-send-email-peng.fan@nxp.com>

On 06/20/2016 03:43 AM, Peng Fan wrote:
> The USBNC_PHYCFG2_ACAENB bit should be cleared to enable the
> OTG ID detection, not set it. When the bit is set, the ACA
> Resistance Detection is enabled, which disables the OTG ID
> detection, because the internal pull up is off.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---

Applied, thanks

> V2:
>  split from V1 to a single patch.
> 
>  drivers/usb/host/ehci-mx6.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> index cc3b11c..069f116 100644
> --- a/drivers/usb/host/ehci-mx6.c
> +++ b/drivers/usb/host/ehci-mx6.c
> @@ -208,8 +208,11 @@ static void usb_power_config(int index)
>  			(0x10000 * index) + USBNC_OFFSET);
>  	void __iomem *phy_cfg2 = (void __iomem *)(&usbnc->phy_cfg2);
>  
> -	/* Enable usb_otg_id detection */
> -	setbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
> +	/*
> +	 * Clear the ACAENB to enable usb_otg_id detection,
> +	 * otherwise it is the ACA detection enabled.
> +	 */
> +	clrbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
>  }
>  
>  int usb_phy_mode(int port)
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-06-20 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20  1:43 [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Peng Fan
2016-06-20  1:43 ` [U-Boot] [PATCH V2 2/2] ehci: mx7: fix otg id detection Peng Fan
2016-06-20 13:58   ` Marek Vasut [this message]
2016-06-20 13:58 ` [U-Boot] [PATCH V2 1/2] ehci: mx7: fix usbnc_regs Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5767F673.2000101@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox