public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] autoboot: remove CONFIG_ZERO_BOOTDELAY_CHECK
Date: Tue, 21 Jun 2016 07:43:07 +0200	[thread overview]
Message-ID: <5768D3EB.1040500@denx.de> (raw)
In-Reply-To: <1466487167-18987-4-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 21.06.2016 07:32, Masahiro Yamada wrote:
> As the help message of CONFIG_BOOTDELAY says, CONFIG_BOOTDELAY=-2
> means the autoboot with no delay, with no abort check even if
> CONFIG_ZERO_BOOTDELAY_CHECK is defined.
>
> To sum up, the autoboot behaves as follows:
>
>   [1] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=y
>      autoboot with no delay, but you can abort it by key input
>
>   [2] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n
>      autoboot with no delay, with no check for abort
>
>   [3] CONFIG_BOOTDELAY=-1
>      disable autoboot
>
>   [4] CONFIG_BOOTDELAY=-2
>      autoboot with no delay, with no check for abort
>
> As you notice, [2] and [4] come to the same result, which means we
> do not need CONFIG_ZERO_BOOTDELAY_CHECK.  We can control all the
> cases only by CONFIG_BOOTDELAY, like this:
>
>   [1] CONFIG_BOOTDELAY=0
>      autoboot with no delay, but you can abort it by key input
>
>   [2] CONFIG_BOOTDELAY=-1
>      disable autoboot
>
>   [3] CONFIG_BOOTDELAY=-2
>      autoboot with no delay, with no check for abort
>
> This commit converts the logic as follow:
>    CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n
>      --> CONFIG_BOOTDELAY=-2
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Looks good, thanks for working on this cleanup.

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2016-06-21  5:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21  5:32 [U-Boot] [PATCH 0/6] autoboot cleanups Masahiro Yamada
2016-06-21  5:32 ` [U-Boot] [PATCH 1/6] ARM: socfpga: move CONFIG_BOOTDELAY to Kconfig for IS1 board Masahiro Yamada
2016-06-21 11:40   ` Pavel Machek
2016-06-22  5:49   ` Heiko Schocher
2016-06-21  5:32 ` [U-Boot] [PATCH 2/6] doc: bootdelay: drop explanation about CONFIG_BOOTDELAY from README Masahiro Yamada
2016-06-21 16:05   ` Simon Glass
2016-06-22  5:49   ` Heiko Schocher
2016-06-21  5:32 ` [U-Boot] [PATCH 3/6] autoboot: remove CONFIG_ZERO_BOOTDELAY_CHECK Masahiro Yamada
2016-06-21  5:43   ` Stefan Roese [this message]
2016-06-21 16:01   ` Igor Grinberg
2016-06-21 16:05   ` Simon Glass
2016-06-22  5:30   ` Vladimir Zapolskiy
2016-06-22  5:50   ` Heiko Schocher
2016-06-22  6:42   ` Christian Riesch
2016-06-22 10:46   ` Hannes Schmelzer
2016-06-21  5:32 ` [U-Boot] [PATCH 4/6] autoboot: rename abortboot_{keyed, normal} to __abortboot Masahiro Yamada
2016-06-21  5:44   ` Stefan Roese
2016-06-21 16:06   ` Simon Glass
2016-06-22  5:51   ` Heiko Schocher
2016-06-21  5:32 ` [U-Boot] [PATCH 5/6] autoboot: move CONFIG_SILENT_CONSOLE handling Masahiro Yamada
2016-06-21  5:46   ` Stefan Roese
2016-06-21 16:06   ` Simon Glass
2016-06-22  5:51   ` Heiko Schocher
2016-06-21  5:32 ` [U-Boot] [PATCH 6/6] autoboot: move bootdelay >= 0 check to abortboot() Masahiro Yamada
2016-06-21  5:47   ` Stefan Roese
2016-06-21 16:06     ` Simon Glass
2016-06-22  5:57   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5768D3EB.1040500@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox