From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 21 Jun 2016 07:43:07 +0200 Subject: [U-Boot] [PATCH 3/6] autoboot: remove CONFIG_ZERO_BOOTDELAY_CHECK In-Reply-To: <1466487167-18987-4-git-send-email-yamada.masahiro@socionext.com> References: <1466487167-18987-1-git-send-email-yamada.masahiro@socionext.com> <1466487167-18987-4-git-send-email-yamada.masahiro@socionext.com> Message-ID: <5768D3EB.1040500@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Masahiro, On 21.06.2016 07:32, Masahiro Yamada wrote: > As the help message of CONFIG_BOOTDELAY says, CONFIG_BOOTDELAY=-2 > means the autoboot with no delay, with no abort check even if > CONFIG_ZERO_BOOTDELAY_CHECK is defined. > > To sum up, the autoboot behaves as follows: > > [1] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=y > autoboot with no delay, but you can abort it by key input > > [2] CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n > autoboot with no delay, with no check for abort > > [3] CONFIG_BOOTDELAY=-1 > disable autoboot > > [4] CONFIG_BOOTDELAY=-2 > autoboot with no delay, with no check for abort > > As you notice, [2] and [4] come to the same result, which means we > do not need CONFIG_ZERO_BOOTDELAY_CHECK. We can control all the > cases only by CONFIG_BOOTDELAY, like this: > > [1] CONFIG_BOOTDELAY=0 > autoboot with no delay, but you can abort it by key input > > [2] CONFIG_BOOTDELAY=-1 > disable autoboot > > [3] CONFIG_BOOTDELAY=-2 > autoboot with no delay, with no check for abort > > This commit converts the logic as follow: > CONFIG_BOOTDELAY=0 && CONFIG_ZERO_BOOTDELAY_CHECK=n > --> CONFIG_BOOTDELAY=-2 > > Signed-off-by: Masahiro Yamada Looks good, thanks for working on this cleanup. Reviewed-by: Stefan Roese Thanks, Stefan