From: Wolfgang Denk <wd@denx.de>
To: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
Cc: u-boot@lists.denx.de, priyanka.jain@nxp.com, ykaukab@suse.de,
festevam@gmail.com, trini@konsulko.com
Subject: Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
Date: Thu, 12 Aug 2021 09:24:22 +0200 [thread overview]
Message-ID: <577080.1628753062@gemini.denx.de> (raw)
In-Reply-To: <20210812072846.39305-1-Zhiqiang.Hou@nxp.com>
Dear Zhiqiang Hou,
In message <20210812072846.39305-1-Zhiqiang.Hou@nxp.com> you wrote:
> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
> index 2711f651d7..c7fdd10cf5 100644
> --- a/include/configs/ls1012afrdm.h
> +++ b/include/configs/ls1012afrdm.h
> @@ -1,6 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0+ */
> /*
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2021 NXP
> */
>
> #ifndef __LS1012ARDB_H__
> @@ -24,7 +25,6 @@
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "verify=no\0" \
> "fdt_high=0xffffffffffffffff\0" \
> - "fdt_addr=0x00f00000\0" \
> "kernel_addr=0x01000000\0" \
> "scriptaddr=0x80000000\0" \
> "fdtheader_addr_r=0x80100000\0" \
> diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
Adding or - like here, even worse - removing just a few lines of
data definitions is certainly nothing where you can claim a
copyright on.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
HR Manager to job candidate "I see you've had no computer training.
Although that qualifies you for upper management, it means you're
under-qualified for our entry level positions."
next prev parent reply other threads:[~2021-08-12 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 7:28 [PATCH] configs: Layerscape: Remove the 'fdt_addr' env Zhiqiang Hou
2021-08-12 7:24 ` Wolfgang Denk [this message]
2021-08-12 8:13 ` Z.Q. Hou
2021-08-12 8:58 ` Wolfgang Denk
2021-08-18 9:29 ` Priyanka Jain (OSS)
2021-08-19 11:29 ` Wolfgang Denk
2021-08-18 10:33 ` Priyanka Jain (OSS)
2021-08-23 3:37 ` Z.Q. Hou
2021-11-09 11:54 ` Priyanka Jain (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577080.1628753062@gemini.denx.de \
--to=wd@denx.de \
--cc=Zhiqiang.Hou@nxp.com \
--cc=festevam@gmail.com \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox