From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 30 Jun 2016 23:09:44 +0200 Subject: [U-Boot] [PATCH] SPL: sunxi: don't force .BSS into DRAM In-Reply-To: <874m8afucb.fsf@dell.be.48ers.dk> References: <20160630002500.2817-1-andre.przywara@arm.com> <7306b594-ad75-8efe-83b6-dc7b2fea5cc4@arm.com> <874m8afucb.fsf@dell.be.48ers.dk> Message-ID: <57758A98.2000204@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/30/2016 07:40 PM, Peter Korsgaard wrote: >>>>>> "Andre" == Andre Przywara writes: > > Hi, > > > I really don't know. This simple bug has cost me at least two hours > > yesterday, since it was the rather innocent access to a variable that > > caused the issue. And if it wouldn't have been for Siarhei to point me > > in the right direction I'd have spend even more time to find a fix. > > Agreed. The toolchain will complain loudly about an overflow of SRAM > space, but not about BSS access before DRAM is available. > I see two problems: - this fixes sunxi and possibly leaves other platforms unfixed - when the spl on sunxi grows some more, the bss won't fit and you'll have a problem again, except much bigger this time I'd rather have this fixed on tiny-printf level with a bit of documentation on why that's done the way it's done. -- Best regards, Marek Vasut