From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: support 'memstart =' in u_boot_utils.find_ram_base()
Date: Wed, 6 Jul 2016 16:49:02 +0200 [thread overview]
Message-ID: <577D1A5E.4020306@gmail.com> (raw)
In-Reply-To: <577D17AA.5030308@wwwdotorg.org>
Am 06.07.2016 um 16:37 schrieb Stephen Warren:
> On 07/06/2016 04:44 AM, Daniel Schwierzeck wrote:
>> Some archs like MIPS or PPC have a different 'bdinfo' output
>> than ARM regarding the memory configuration. Also support
>> 'memstart = 0x*' in u_boot_utils.find_ram_base() to make
>> all tests requiring the RAM base working on those archs.
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> ... although wouldn't it be better to fix the bdinfo command so that it
> printed the same thing on all architectures?
yes, but bdinfo isn't the only one affected. Currently we have two variants in "struct bd_info" of how to store the memory configuration:
- bi_memstart and bi_memsize
- struct bi_dram[CONFIG_NR_DRAM_BANKS] if a board or arch defines CONFIG_NR_DRAM_BANKS
Maybe we could unify this one day. But this requires changes to other commands and generic board init. Until then test/py should support both variants.
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160706/d716974b/attachment.sig>
next prev parent reply other threads:[~2016-07-06 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 10:44 [U-Boot] [PATCH] test/py: support 'memstart =' in u_boot_utils.find_ram_base() Daniel Schwierzeck
2016-07-06 14:37 ` Stephen Warren
2016-07-06 14:49 ` Daniel Schwierzeck [this message]
2016-07-09 13:24 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D1A5E.4020306@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox