[U-Boot] [PATCH 14/14] test: Convert the vboot test to test/py

Simon Glass
2016-07-03T23:19:03Z

Hi Teddy,

On 3 July 2016 at 15:38, Teddy Reed <teddy.reed@gmail.com> wrote:
> Hi Simon,
>
> On Sun, Jul 3, 2016 at 8:40 AM, Simon Glass <sjg@chromium.org> wrote:
>> Now that we have a suitable test framework we should move all tests into it.
>> The vboot test is a suitable candidate. Rewrite it in Python and move the
>> data files into an appropriate directory.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> test/README | 1 -
>> test/py/tests/test_vboot.py | 185 ++++++++++++++++++++++
>> test/{ => py/tests}/vboot/sandbox-kernel.dts | 0
>> test/{ => py/tests}/vboot/sandbox-u-boot.dts | 0
>> test/{ => py/tests}/vboot/sign-configs-sha1.its | 0
>> test/{ => py/tests}/vboot/sign-configs-sha256.its | 0
>> test/{ => py/tests}/vboot/sign-images-sha1.its | 0
>> test/{ => py/tests}/vboot/sign-images-sha256.its | 0
>> test/vboot/.gitignore | 3 -
>> test/vboot/vboot_test.sh | 151 ------------------
>> 10 files changed, 185 insertions(+), 155 deletions(-)
>> create mode 100644 test/py/tests/test_vboot.py
>> rename test/{ => py/tests}/vboot/sandbox-kernel.dts (100%)
>> rename test/{ => py/tests}/vboot/sandbox-u-boot.dts (100%)
>> rename test/{ => py/tests}/vboot/sign-configs-sha1.its (100%)
>> rename test/{ => py/tests}/vboot/sign-configs-sha256.its (100%)
>> rename test/{ => py/tests}/vboot/sign-images-sha1.its (100%)
>> rename test/{ => py/tests}/vboot/sign-images-sha256.its (100%)
>> delete mode 100644 test/vboot/.gitignore
>> delete mode 100755 test/vboot/vboot_test.sh

[snip]

>
> Thanks for this refactor! If the comments related to the sh to Python
> are too nit-picky we can certainly change and expand the test harness
> within additional patches later.

Thanks for the high-quality review... I'm expecting that Stephen will
have a few things to say about how best to fit things into the pytest
stuff too. So I'll hold off a bit before respinning. But I want to
avoid any more expansion of the vboot shell script.

Regards,
Simon