From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 7 Jul 2016 12:01:50 -0600
Subject: [U-Boot] [PATCH 14/14] test: Convert the vboot test to test/py
In-Reply-To: <CADUykepCP8u0q49v0suby0vhVFeqK28KD-msd8L7HrdKqPFkqQ@mail.gmail.com>
References: <1467560446-10628-1-git-send-email-sjg@chromium.org>
 <1467560446-10628-15-git-send-email-sjg@chromium.org>
 <CADUykepCP8u0q49v0suby0vhVFeqK28KD-msd8L7HrdKqPFkqQ@mail.gmail.com>
Message-ID: <577E990E.1010005@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/03/2016 03:38 PM, Teddy Reed wrote:
> Hi Simon,
>
> On Sun, Jul 3, 2016 at 8:40 AM, Simon Glass <sjg@chromium.org> wrote:
>> Now that we have a suitable test framework we should move all tests into it.
>> The vboot test is a suitable candidate. Rewrite it in Python and move the
>> data files into an appropriate directory.

>> +    datadir = 'test/py/tests/vboot/'
>> +    fit = '%stest.fit' % tmpdir
>> +    mkimage = cons.config.build_dir + '/tools/mkimage'
>> +    fit_check_sign = cons.config.build_dir + '/tools/fit_check_sign'
>> +    dtc_args = '-I dts -O dtb -i %s' % tmpdir
>> +    dtb = '%ssandbox-u-boot.dtb' % tmpdir
>> +    sig_node = '/configurations/conf at 1/signature at 1'
>
> If these variables are used throughout the tests like globals, should
> they be DATADIR, MKIMAGE, etc?

I'd prefer not to use all-caps variable names.