public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board: move all the rockchip board in one folder
Date: Mon, 11 Jul 2016 11:14:46 +0800	[thread overview]
Message-ID: <57830F26.5080407@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ2gieRWZzTdbRXS8uZCdVYWZG1NHZX5Rz7_4D1wpxyRsQ@mail.gmail.com>

Hi Simon,

On 07/09/2016 10:38 PM, Simon Glass wrote:
> Hi Kevin,
>
> On 7 July 2016 at 21:49, Eddie Cai <eddie.cai.kernel@gmail.com> wrote:
>> 2016-07-08 11:30 GMT+08:00 Kever Yang <kever.yang@rock-chips.com>:
>>> The 'evb_rk3036' and 'kylin' is not a vendor name, let's replace them
>>> to 'rockchip' which is a real _vendor_ name, and meet the architecure
>>> 'board/<vendor>/<board-name>/'.
>>>
>>> More boards from rockchip like evb_rk3288, evb_rk3399 will comes later.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> Reviewed-by: Eddie Cai <eddie.cai.kernel@gmail.com>
>>> ---
>>>   arch/arm/mach-rockchip/rk3036/Kconfig      |  4 +-
>>>   board/evb_rk3036/evb_rk3036/Kconfig        | 15 ------
>>>   board/evb_rk3036/evb_rk3036/MAINTAINERS    |  0
>>>   board/evb_rk3036/evb_rk3036/Makefile       |  7 ---
>>>   board/evb_rk3036/evb_rk3036/evb_rk3036.c   | 49 ------------------
>>>   board/kylin/kylin_rk3036/Kconfig           | 15 ------
>>>   board/kylin/kylin_rk3036/MAINTAINERS       |  0
>>>   board/kylin/kylin_rk3036/Makefile          |  7 ---
>>>   board/kylin/kylin_rk3036/kylin_rk3036.c    | 81 ------------------------------
>>>   board/rockchip/evb_rk3036/Kconfig          | 15 ++++++
>>>   board/rockchip/evb_rk3036/MAINTAINERS      |  0
>>>   board/rockchip/evb_rk3036/Makefile         |  7 +++
>>>   board/rockchip/evb_rk3036/evb_rk3036.c     | 49 ++++++++++++++++++
>>>   board/rockchip/kylin_rk3036/Kconfig        | 15 ++++++
>>>   board/rockchip/kylin_rk3036/MAINTAINERS    |  0
>>>   board/rockchip/kylin_rk3036/Makefile       |  7 +++
>>>   board/rockchip/kylin_rk3036/kylin_rk3036.c | 81 ++++++++++++++++++++++++++++++
>>>   17 files changed, 176 insertions(+), 176 deletions(-)
>>>   delete mode 100644 board/evb_rk3036/evb_rk3036/Kconfig
>>>   delete mode 100644 board/evb_rk3036/evb_rk3036/MAINTAINERS
>>>   delete mode 100644 board/evb_rk3036/evb_rk3036/Makefile
>>>   delete mode 100644 board/evb_rk3036/evb_rk3036/evb_rk3036.c
>>>   delete mode 100644 board/kylin/kylin_rk3036/Kconfig
>>>   delete mode 100644 board/kylin/kylin_rk3036/MAINTAINERS
>>>   delete mode 100644 board/kylin/kylin_rk3036/Makefile
>>>   delete mode 100644 board/kylin/kylin_rk3036/kylin_rk3036.c
>>>   create mode 100644 board/rockchip/evb_rk3036/Kconfig
>>>   create mode 100644 board/rockchip/evb_rk3036/MAINTAINERS
>>>   create mode 100644 board/rockchip/evb_rk3036/Makefile
>>>   create mode 100644 board/rockchip/evb_rk3036/evb_rk3036.c
>>>   create mode 100644 board/rockchip/kylin_rk3036/Kconfig
>>>   create mode 100644 board/rockchip/kylin_rk3036/MAINTAINERS
>>>   create mode 100644 board/rockchip/kylin_rk3036/Makefile
>>>   create mode 100644 board/rockchip/kylin_rk3036/kylin_rk3036.c
> Did you use patman for these? I think it should show these as renames
> rather than delete/add deltas.
Sorry, I didn't use the patman, I use git  format-patch and get 
send-email instead,
I will re-send this patch again with patman.

BTW, I get below error when I use patman, I have no idea about where I 
need to define the 'board' node.

Cleaned 1 patches
Traceback (most recent call last):
   File "./tools/patman/patman", line 159, in <module>
     options.add_maintainers)
   File "u-boot/tools/patman/series.py", line 225, in MakeCcFile
     raise_on_error=raise_on_error)
   File "u-boot/tools/patman/gitutil.py", line 326, in BuildEmailList
     raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
   File "u-boot/tools/patman/gitutil.py", line 500, in LookupEmail
     raise ValueError, msg
ValueError: Alias 'board' not found

Thanks,
- Kever
>
> Regards,
> Simon
>
>
>

  reply	other threads:[~2016-07-11  3:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08  3:30 [U-Boot] [PATCH] board: move all the rockchip board in one folder Kever Yang
2016-07-08  3:49 ` Eddie Cai
2016-07-09 14:38   ` Simon Glass
2016-07-11  3:14     ` Kever Yang [this message]
2016-07-11 23:53       ` Simon Glass
2016-07-08  3:53 ` Ziyuan Xu
2016-07-09 14:38   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57830F26.5080407@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox