From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver/net/fec: support fixed speed connection
Date: Mon, 11 Jul 2016 16:23:47 +0200 [thread overview]
Message-ID: <5783ABF3.2050303@denx.de> (raw)
In-Reply-To: <1466590034-15127-1-git-send-email-oe5hpm@oevsv.at>
Hi Hannes,
On 22/06/2016 12:07, Hannes Schmelzer wrote:
> If MAC is directly connected to another MAC (like a switch for example)
> we don't need to probe for a phy, autoneogation and so on. We simply
> have to setup speed.
>
> Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at>
> ---
>
> doc/README.fec_mxc | 5 +++++
> drivers/net/fec_mxc.c | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/doc/README.fec_mxc b/doc/README.fec_mxc
> index ed7e47d..9ca6ac2 100644
> --- a/doc/README.fec_mxc
> +++ b/doc/README.fec_mxc
> @@ -27,6 +27,11 @@ CONFIG_FEC_MXC_PHYADDR
> Optional, selects the exact phy address that should be connected
> and function fecmxc_initialize will try to initialize it.
>
> +CONFIG_FEC_FIXED_SPEED
> + Optional, selects a fixed speed on the MAC interface without asking some
> + phy. This is usefull if there is a direct MAC <-> MAC connection, for
> + example if the CPU is connected directly via the RGMII interface to a
> + ethernet-switch.
>
> Reading the ethaddr from the SoC eFuses:
> if CONFIG_FEC_MXC is defined and the U-Boot environment does not contain the
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 360f8e4..e871b3e 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -233,6 +233,7 @@ static int miiphy_restart_aneg(struct eth_device *dev)
> return ret;
> }
>
> +#ifndef CONFIG_FEC_FIXED_SPEED
> static int miiphy_wait_aneg(struct eth_device *dev)
> {
> uint32_t start;
> @@ -260,6 +261,7 @@ static int miiphy_wait_aneg(struct eth_device *dev)
>
> return 0;
> }
> +#endif /* CONFIG_FEC_FIXED_SPEED */
> #endif
>
> static int fec_rx_task_enable(struct fec_priv *fec)
> @@ -502,6 +504,8 @@ static int fec_open(struct eth_device *edev)
> }
> speed = fec->phydev->speed;
> }
> +#elif CONFIG_FEC_FIXED_SPEED
> + speed = CONFIG_FEC_FIXED_SPEED;
> #else
> miiphy_wait_aneg(edev);
> speed = miiphy_speed(edev->name, fec->phy_id);
>
Really I had already sent a patch for this issue, and I merged this into
u-boot-imx, - next
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=57b7371e24e429ee37403cfb084d142cf7699bd7
Anyway, your patch is more complete as mine. I will drop my patch and
substitute with your.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2016-07-11 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 10:07 [U-Boot] [PATCH] driver/net/fec: support fixed speed connection Hannes Schmelzer
2016-07-06 15:13 ` Joe Hershberger
2016-07-11 14:23 ` Stefano Babic [this message]
2016-07-11 14:36 ` Hannes Schmelzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5783ABF3.2050303@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox