From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] efi_loader: Improve .dtb search for arm64
Date: Tue, 12 Jul 2016 10:05:51 -0600 [thread overview]
Message-ID: <5785155F.3060305@wwwdotorg.org> (raw)
In-Reply-To: <e7bb2eed-5208-e4b6-ad93-257041f4354f@suse.de>
On 07/12/2016 01:29 AM, Alexander Graf wrote:
>
>
> On 12.07.16 06:21, Andreas F?rber wrote:
>> On arm64 Linux device trees are organized by SoC vendor. Therefore we
>> need to search the vendor subdirectory as well.
>>
>> Since the SoC vendor may be different from ${vendor}, introduce a new
>> ${soc_vendor}. If this is not set, the behavior remains unchanged.
>>
>> Cc: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Andreas F?rber <afaerber@suse.de>
>
> Stephen had pretty strong opinions on the naming, mostly because "pxe
> boot" uses the same naming scheme. So we should either change it there
> as well to stay consistent or just make the implicit ruling always work :).
>
> I guess the best case would be to fix up the path names of boards so
> that $vendor is always $soc_vendor. Do you have an example where that
> wouldn't work?
All I'll say is that if the "auto calculation" algorithm of
${soc}-${board}.dtb doesn't work, U-Boot should set ${fdtfile} with the
correct full name. Introducing other more complex "auto calculation" is
just going to lead to more complexity and yet still not solve 100% of
the cases, which will be confusing.
I'm unlikely to review any other aspects of the series, since I'm still
quite disappointed that distros wouldn't engage in the discussions boot
methods and agree on one solution, and that config_distro*.h is being
abused as a dumping ground for tons of different boot methods; the whole
point of it was to unify on *one* method that distros could rely upon,
which is the opposite of where it's now going:-(
next prev parent reply other threads:[~2016-07-12 16:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 4:21 [U-Boot] [PATCH 0/6] efi_loader: Improvements to .dtb handling Andreas Färber
2016-07-12 4:21 ` [U-Boot] [PATCH 1/6] efi_loader: Cosmetic distro script cleanups Andreas Färber
2016-07-12 4:21 ` [U-Boot] [PATCH 2/6] efi_loader: Respect $boot_prefixes for EFI .dtb search Andreas Färber
2016-07-12 4:21 ` [U-Boot] [PATCH 3/6] efi_loader: Search .dtb on non-EFI partitions Andreas Färber
2016-07-12 7:25 ` Alexander Graf
2016-07-12 11:45 ` Andreas Färber
2016-07-12 4:21 ` [U-Boot] [PATCH 4/6] efi_loader: Improve .dtb search for arm64 Andreas Färber
2016-07-12 7:29 ` Alexander Graf
2016-07-12 12:38 ` Andreas Färber
2016-07-12 13:49 ` Andreas Färber
2016-07-12 16:05 ` Stephen Warren [this message]
2016-07-12 14:50 ` Tom Rini
2016-07-12 15:59 ` Andreas Färber
2016-07-12 18:05 ` Tom Rini
2016-07-12 4:21 ` [U-Boot] [PATCH 5/6] dragonboard410c: Set soc_vendor Andreas Färber
2016-07-12 4:21 ` [U-Boot] [PATCH 6/6] efi_loader: Display which .dtb we found Andreas Färber
2016-07-12 7:30 ` Alexander Graf
2016-07-12 12:45 ` Andreas Färber
2016-07-12 14:25 ` Alexander Graf
2016-07-12 14:27 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5785155F.3060305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox