[U-Boot] [PATCH 4/6] efi_loader: Improve .dtb search for arm64

Stephen Warren
2016-07-12T16:05:51Z

On 07/12/2016 01:29 AM, Alexander Graf wrote:
>
>
> On 12.07.16 06:21, Andreas F?rber wrote:
>> On arm64 Linux device trees are organized by SoC vendor. Therefore we
>> need to search the vendor subdirectory as well.
>>
>> Since the SoC vendor may be different from ${vendor}, introduce a new
>> ${soc_vendor}. If this is not set, the behavior remains unchanged.
>>
>> Cc: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Andreas F?rber <afaerber@suse.de>
>
> Stephen had pretty strong opinions on the naming, mostly because "pxe
> boot" uses the same naming scheme. So we should either change it there
> as well to stay consistent or just make the implicit ruling always work :).
>
> I guess the best case would be to fix up the path names of boards so
> that $vendor is always $soc_vendor. Do you have an example where that
> wouldn't work?

All I'll say is that if the "auto calculation" algorithm of
${soc}-${board}.dtb doesn't work, U-Boot should set ${fdtfile} with the
correct full name. Introducing other more complex "auto calculation" is
just going to lead to more complexity and yet still not solve 100% of
the cases, which will be confusing.

I'm unlikely to review any other aspects of the series, since I'm still
quite disappointed that distros wouldn't engage in the discussions boot
methods and agree on one solution, and that config_distro*.h is being
abused as a dumping ground for tons of different boot methods; the whole
point of it was to unify on *one* method that distros could rely upon,
which is the opposite of where it's now going:-(