From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 12 Jul 2016 10:08:05 -0600 Subject: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock In-Reply-To: References: <20160620182505.21075.54136.stgit@obelix.dresden.micronet24.de> <20160620182636.21075.97627.stgit@obelix.dresden.micronet24.de> Message-ID: <578515E5.6010704@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/12/2016 10:02 AM, Simon Glass wrote: > +Stephen > > Hi Benjamin, > > On 20 June 2016 at 12:26, Benjamin Tietz wrote: >> From: Benjamin Tietz >> >> Currently, clocks can be enabled, only. To be feature-complete - and allow >> a bit of power-saving in applications - disabling a clock should be >> possible, too. >> >> This extend the API of the DM clock driver to allow a clock to be disabled. >> >> The corresponding operation is optional for not breaking existing drivers. > > What does this mean? I can't see how it is optional. > > Also please can you rebase to mainline and resend, as the API has > changed (sorry). include/clk.h already contains a clk_disable() function. I suspect you can just go ahead and implement it and ignore this patch?