* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial @ 2016-07-14 3:51 Kever Yang 2016-07-14 4:26 ` Andreas Färber 2016-07-15 3:20 ` Simon Glass 0 siblings, 2 replies; 7+ messages in thread From: Kever Yang @ 2016-07-14 3:51 UTC (permalink / raw) To: u-boot Add support for rockchip rk33 series Soc like rk3368 and rk3399 Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 72621fd..9ec7eb2 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -56,6 +56,7 @@ struct spl_info { static struct spl_info spl_infos[] = { { "rk3036", "RK30", 0x1000 }, { "rk3288", "RK32", 0x8000 }, + { "rk33xx", "RK33", 0x20000 }, }; static unsigned char rc4_key[16] = { -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-14 3:51 [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial Kever Yang @ 2016-07-14 4:26 ` Andreas Färber 2016-07-15 1:40 ` Kever Yang 2016-07-15 3:20 ` Simon Glass 1 sibling, 1 reply; 7+ messages in thread From: Andreas Färber @ 2016-07-14 4:26 UTC (permalink / raw) To: u-boot Am 14.07.2016 um 05:51 schrieb Kever Yang: > Add support for rockchip rk33 series Soc like rk3368 and rk3399 > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > tools/rkcommon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/rkcommon.c b/tools/rkcommon.c > index 72621fd..9ec7eb2 100644 > --- a/tools/rkcommon.c > +++ b/tools/rkcommon.c > @@ -56,6 +56,7 @@ struct spl_info { > static struct spl_info spl_infos[] = { > { "rk3036", "RK30", 0x1000 }, > { "rk3288", "RK32", 0x8000 }, > + { "rk33xx", "RK33", 0x20000 }, Is xx really future-safe or would it be better to have two lines with the exact model names as before? Cheers, Andreas > }; > > static unsigned char rc4_key[16] = { > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-14 4:26 ` Andreas Färber @ 2016-07-15 1:40 ` Kever Yang 0 siblings, 0 replies; 7+ messages in thread From: Kever Yang @ 2016-07-15 1:40 UTC (permalink / raw) To: u-boot Hi Andreas, On 07/14/2016 12:26 PM, Andreas F?rber wrote: > Am 14.07.2016 um 05:51 schrieb Kever Yang: >> Add support for rockchip rk33 series Soc like rk3368 and rk3399 >> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >> --- >> >> tools/rkcommon.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/rkcommon.c b/tools/rkcommon.c >> index 72621fd..9ec7eb2 100644 >> --- a/tools/rkcommon.c >> +++ b/tools/rkcommon.c >> @@ -56,6 +56,7 @@ struct spl_info { >> static struct spl_info spl_infos[] = { >> { "rk3036", "RK30", 0x1000 }, >> { "rk3288", "RK32", 0x8000 }, >> + { "rk33xx", "RK33", 0x20000 }, > Is xx really future-safe or would it be better to have two lines with > the exact model names as before? Two information here, one is TAG 'RK33' which used by bootrom, they are the same for rk33 series SoC; another is SPL size which is depend on IRAM size, this is different for different SoC, rk3368 is smaller than rk3399. I will use rk3399 first, but we may need to optimize the size limit later for the tool, because the image in Rockchip IDB format could be two parts, one like SPL should be run in IRAM, and another one like U-boot can be run in DRAM, the tool only consider the SPL part now. Thanks, - Kever > > Cheers, > Andreas > >> }; >> >> static unsigned char rc4_key[16] = { >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-14 3:51 [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial Kever Yang 2016-07-14 4:26 ` Andreas Färber @ 2016-07-15 3:20 ` Simon Glass 2016-07-15 3:56 ` Simon Glass 1 sibling, 1 reply; 7+ messages in thread From: Simon Glass @ 2016-07-15 3:20 UTC (permalink / raw) To: u-boot On 13 July 2016 at 21:51, Kever Yang <kever.yang@rock-chips.com> wrote: > Add support for rockchip rk33 series Soc like rk3368 and rk3399 > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > tools/rkcommon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/rkcommon.c b/tools/rkcommon.c > index 72621fd..9ec7eb2 100644 > --- a/tools/rkcommon.c > +++ b/tools/rkcommon.c > @@ -56,6 +56,7 @@ struct spl_info { > static struct spl_info spl_infos[] = { > { "rk3036", "RK30", 0x1000 }, > { "rk3288", "RK32", 0x8000 }, > + { "rk33xx", "RK33", 0x20000 }, > }; > > static unsigned char rc4_key[16] = { > -- > 1.9.1 > > Acked-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-15 3:20 ` Simon Glass @ 2016-07-15 3:56 ` Simon Glass 2016-07-16 16:04 ` Andreas Färber 0 siblings, 1 reply; 7+ messages in thread From: Simon Glass @ 2016-07-15 3:56 UTC (permalink / raw) To: u-boot On 14 July 2016 at 21:20, Simon Glass <sjg@chromium.org> wrote: > On 13 July 2016 at 21:51, Kever Yang <kever.yang@rock-chips.com> wrote: >> Add support for rockchip rk33 series Soc like rk3368 and rk3399 >> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >> --- >> >> tools/rkcommon.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/rkcommon.c b/tools/rkcommon.c >> index 72621fd..9ec7eb2 100644 >> --- a/tools/rkcommon.c >> +++ b/tools/rkcommon.c >> @@ -56,6 +56,7 @@ struct spl_info { >> static struct spl_info spl_infos[] = { >> { "rk3036", "RK30", 0x1000 }, >> { "rk3288", "RK32", 0x8000 }, >> + { "rk33xx", "RK33", 0x20000 }, >> }; >> >> static unsigned char rc4_key[16] = { >> -- >> 1.9.1 >> >> > > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-rockchip, thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-15 3:56 ` Simon Glass @ 2016-07-16 16:04 ` Andreas Färber 2016-07-17 14:14 ` Simon Glass 0 siblings, 1 reply; 7+ messages in thread From: Andreas Färber @ 2016-07-16 16:04 UTC (permalink / raw) To: u-boot Simon, Am 15.07.2016 um 05:56 schrieb Simon Glass: > On 14 July 2016 at 21:20, Simon Glass <sjg@chromium.org> wrote: >> On 13 July 2016 at 21:51, Kever Yang <kever.yang@rock-chips.com> wrote: >>> Add support for rockchip rk33 series Soc like rk3368 and rk3399 >>> >>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >>> --- >>> >>> tools/rkcommon.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/rkcommon.c b/tools/rkcommon.c >>> index 72621fd..9ec7eb2 100644 >>> --- a/tools/rkcommon.c >>> +++ b/tools/rkcommon.c >>> @@ -56,6 +56,7 @@ struct spl_info { >>> static struct spl_info spl_infos[] = { >>> { "rk3036", "RK30", 0x1000 }, >>> { "rk3288", "RK32", 0x8000 }, >>> + { "rk33xx", "RK33", 0x20000 }, >>> }; >>> >>> static unsigned char rc4_key[16] = { >>> -- >>> 1.9.1 >>> >>> >> >> Acked-by: Simon Glass <sjg@chromium.org> > > Applied to u-boot-rockchip, thanks! Didn't he just reply that it should be 3399 instead of 33xx because 3368 needs a different third column? Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial 2016-07-16 16:04 ` Andreas Färber @ 2016-07-17 14:14 ` Simon Glass 0 siblings, 0 replies; 7+ messages in thread From: Simon Glass @ 2016-07-17 14:14 UTC (permalink / raw) To: u-boot Hi Andreas, On 16 July 2016 at 10:04, Andreas F?rber <afaerber@suse.de> wrote: > Simon, > > Am 15.07.2016 um 05:56 schrieb Simon Glass: >> On 14 July 2016 at 21:20, Simon Glass <sjg@chromium.org> wrote: >>> On 13 July 2016 at 21:51, Kever Yang <kever.yang@rock-chips.com> wrote: >>>> Add support for rockchip rk33 series Soc like rk3368 and rk3399 >>>> >>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >>>> --- >>>> >>>> tools/rkcommon.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/tools/rkcommon.c b/tools/rkcommon.c >>>> index 72621fd..9ec7eb2 100644 >>>> --- a/tools/rkcommon.c >>>> +++ b/tools/rkcommon.c >>>> @@ -56,6 +56,7 @@ struct spl_info { >>>> static struct spl_info spl_infos[] = { >>>> { "rk3036", "RK30", 0x1000 }, >>>> { "rk3288", "RK32", 0x8000 }, >>>> + { "rk33xx", "RK33", 0x20000 }, >>>> }; >>>> >>>> static unsigned char rc4_key[16] = { >>>> -- >>>> 1.9.1 >>>> >>>> >>> >>> Acked-by: Simon Glass <sjg@chromium.org> >> >> Applied to u-boot-rockchip, thanks! > > Didn't he just reply that it should be 3399 instead of 33xx because 3368 > needs a different third column? Ah yes. We don't actually have 3368, but it would be good to fix the string now. Kever can you please send a patch? Regards, Simon ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-17 14:14 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-07-14 3:51 [U-Boot] [PATCH] mkimage: rockchip: add suport for rk33 serial Kever Yang 2016-07-14 4:26 ` Andreas Färber 2016-07-15 1:40 ` Kever Yang 2016-07-15 3:20 ` Simon Glass 2016-07-15 3:56 ` Simon Glass 2016-07-16 16:04 ` Andreas Färber 2016-07-17 14:14 ` Simon Glass
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox