public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] dm: clk: Remove simple version of clk_get_by_index/name()
Date: Mon, 18 Jul 2016 08:57:52 +0200	[thread overview]
Message-ID: <578C7DF0.3070407@xilinx.com> (raw)
In-Reply-To: <57890484.60503@wwwdotorg.org>

Hi Simon,

On 15.7.2016 17:43, Stephen Warren wrote:
> On 07/15/2016 01:02 AM, Michal Simek wrote:
>> Simple version of clk_get_by_index() added by:
>> "dm: clk: Add a simple version of clk_get_by_index()"
>> (sha1: a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44)
>> is only working for #clock-cells=<1> but not for
>> any other values. Fixed clocks is using #clock-cells=<0>
>> which requires full implementation.
>>
>> Remove simplified versions of clk_get_by_index() and use full version.
>> Also remove empty clk_get_by_name() which is failing when it is called
>> which is useless.
> 
> This seems reasonable to me,
> Acked-by: Stephen Warren <swarren@nvidia.com>

I see your patch
"dm: clk: Add support for of-platdata"
(sha1: 	7423daa60eb30b6613dfc19a51c55de23fd4d703)
has been merged to the tree and it is in conflict with this patch.
Is there any problem about using full version and just remove the whole
SPL part?

Thanks,
Michal

  reply	other threads:[~2016-07-18  6:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  7:02 [U-Boot] [PATCH v2] dm: clk: Remove simple version of clk_get_by_index/name() Michal Simek
2016-07-15 15:43 ` Stephen Warren
2016-07-18  6:57   ` Michal Simek [this message]
2016-07-18 11:20     ` Simon Glass
2016-07-19  6:22       ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578C7DF0.3070407@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox