public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: Fix compilation warnings for arm64
Date: Mon, 18 Jul 2016 09:07:11 +0200	[thread overview]
Message-ID: <578C801F.2090600@xilinx.com> (raw)
In-Reply-To: <CAPnjgZ0fOBXSfKU4ASZhL0wdw0mAm0Jx-9ukgb65eYuU6xJxQQ@mail.gmail.com>

Hi Simon,

On 17.7.2016 16:12, Simon Glass wrote:
> Hi Michal,
> 
> On 15 July 2016 at 00:48, Michal Simek <michal.simek@xilinx.com> wrote:
>> Make code 64bit aware.
>>
>> Warnings:
>> +../arch/arm/lib/spl.c: In function ?jump_to_image_linux?:
>> +../arch/arm/lib/spl.c:63:3: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
>> +../common/spl/spl_fat.c: In function ?spl_load_image_fat?:
>> +../common/spl/spl_fat.c:91:33: warning: cast to pointer from integer
>> of different size [-Wint-to-pointer-cast]
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  arch/arm/lib/spl.c   | 2 +-
>>  common/spl/spl_fat.c | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> You could use map_sysmem() / unmap_sysmem() to convert a ulong address
> into a pointer.

Isn't this used more for remapping with non zero length?
I see in the code that people are using it just for conversion but the
question is if this is right usage.

Thanks,
Michal

  reply	other threads:[~2016-07-18  7:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  6:48 [U-Boot] [PATCH] spl: Fix compilation warnings for arm64 Michal Simek
2016-07-17 14:12 ` Simon Glass
2016-07-18  7:07   ` Michal Simek [this message]
2016-07-22  3:21     ` Simon Glass
2016-07-22  7:23       ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578C801F.2090600@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox