[U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP

[U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP

[Murali Karicheri]

commit 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
#ifdeffery") refactored code, however K2HKLE_MSMC_SEGMENT_QM_PDSP is
left under a macro KS2_MSMC_SEGMENT_QM_PDSP which is no longer valid.
This, in effect disabled DMA coherency for QM PDSP.

Given that msmc_k2hkle_common_setup is valid for all K2H/K/L/E SoCs,
the #ifdef should been removed in the first place. Do the same.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/mach-keystone/init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-keystone/init.c b/arch/arm/mach-keystone/init.c
index 3b6d5ef..6e5a1e1 100644
--- a/arch/arm/mach-keystone/init.c
+++ b/arch/arm/mach-keystone/init.c
@@ -101,9 +101,7 @@ static void msmc_k2hkle_common_setup(void)
 	msmc_share_all_segments(KS2_MSMC_SEGMENT_C6X_0);
 	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_ARM);
 	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_NETCP);
-#ifdef KS2_MSMC_SEGMENT_QM_PDSP
 	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_QM_PDSP);
-#endif
 	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_PCIE0);
 	msmc_share_all_segments(KS2_MSMC_SEGMENT_DEBUG);
 }
-- 
1.9.1

[U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP

[Tom Rini]

On Mon, Jul 18, 2016 at 11:42:48AM -0400, Murali Karicheri wrote:

> commit 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
> #ifdeffery") refactored code, however K2HKLE_MSMC_SEGMENT_QM_PDSP is
> left under a macro KS2_MSMC_SEGMENT_QM_PDSP which is no longer valid.
> This, in effect disabled DMA coherency for QM PDSP.
> 
> Given that msmc_k2hkle_common_setup is valid for all K2H/K/L/E SoCs,
> the #ifdef should been removed in the first place. Do the same.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Acked-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160718/bf2fe79f/attachment.sig>

[U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP

[Nishanth Menon]

On 07/18/2016 10:42 AM, Murali Karicheri wrote:
> commit 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
> #ifdeffery") refactored code, however K2HKLE_MSMC_SEGMENT_QM_PDSP is
> left under a macro KS2_MSMC_SEGMENT_QM_PDSP which is no longer valid.
> This, in effect disabled DMA coherency for QM PDSP.
>
> Given that msmc_k2hkle_common_setup is valid for all K2H/K/L/E SoCs,
> the #ifdef should been removed in the first place. Do the same.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> ---
>   arch/arm/mach-keystone/init.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-keystone/init.c b/arch/arm/mach-keystone/init.c
> index 3b6d5ef..6e5a1e1 100644
> --- a/arch/arm/mach-keystone/init.c
> +++ b/arch/arm/mach-keystone/init.c
> @@ -101,9 +101,7 @@ static void msmc_k2hkle_common_setup(void)
>   	msmc_share_all_segments(KS2_MSMC_SEGMENT_C6X_0);
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_ARM);
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_NETCP);
> -#ifdef KS2_MSMC_SEGMENT_QM_PDSP
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_QM_PDSP);
> -#endif
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_PCIE0);
>   	msmc_share_all_segments(KS2_MSMC_SEGMENT_DEBUG);
>   }
>
please add:
Fixes: 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
ifdeffery")


-- 
Regards,
Nishanth Menon