public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: dw_mmc: reduce timeout detection cycle
Date: Tue, 19 Jul 2016 11:03:03 +0900	[thread overview]
Message-ID: <578D8A57.7000404@samsung.com> (raw)
In-Reply-To: <1468892302-3956-1-git-send-email-xzy.xu@rock-chips.com>

Hi Ziyuan,

On 07/19/2016 10:38 AM, Ziyuan Xu wrote:
> It's no need to speed 10 seconds to wait the mmc device out from busy
> status. 500 milliseconds enough.

I agreed that 10 seconds is too big..
Could you explain more how you get 500ms and feel enough?

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> ---
> 
>  drivers/mmc/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 2cf7bae..790a166 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -195,7 +195,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>  	ALLOC_CACHE_ALIGN_BUFFER(struct dwmci_idmac, cur_idmac,
>  				 data ? DIV_ROUND_UP(data->blocks, 8) : 0);
>  	int ret = 0, flags = 0, i;
> -	unsigned int timeout = 100000;
> +	unsigned int timeout = 500;
>  	u32 retry = 100000;
>  	u32 mask, ctrl;
>  	ulong start = get_timer(0);
> 

  reply	other threads:[~2016-07-19  2:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160719013855epcas1p473dab263942467b94c8b5f1a89271d5b@epcas1p4.samsung.com>
2016-07-19  1:38 ` [U-Boot] [PATCH] mmc: dw_mmc: reduce timeout detection cycle Ziyuan Xu
2016-07-19  2:03   ` Jaehoon Chung [this message]
2016-07-19  2:33     ` Ziyuan Xu
2016-07-19  4:22       ` Jaehoon Chung
2016-07-19  7:40         ` Ziyuan Xu
2016-07-19  7:51           ` Jaehoon Chung
2016-07-19  8:08             ` Ziyuan Xu
2016-07-25  2:07               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578D8A57.7000404@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox