From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fix the output format
Date: Tue, 19 Jul 2016 19:35:36 +0900 [thread overview]
Message-ID: <578E0278.20407@samsung.com> (raw)
In-Reply-To: <1468923268-5931-1-git-send-email-xzy.xu@rock-chips.com>
Hi Ziyuan,
On 07/19/2016 07:14 PM, Ziyuan Xu wrote:
> It's nicer to see this:
>
> => mmc list
> dwmmc at ff0c0000: 0
> dwmmc at ff0f0000: 1 (eMMC)
>
> than this:
>
> => mmc list
> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>
> With the latter, it's much clearer which mmc devices are on.
You're right. After applied your patch, it may display like mmc-legacy type.
If add the comment in more detail,
How about "Display mmc list information like mmc-legacy type." ? :)
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> ---
>
> drivers/mmc/mmc-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 38ced41..beebc70 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>
> for (uclass_first_device(UCLASS_MMC, &dev);
> dev;
> - uclass_next_device(&dev)) {
> + uclass_next_device(&dev), first = false) {
> struct mmc *m = mmc_get_mmc_dev(dev);
>
> if (!first) {
>
next prev parent reply other threads:[~2016-07-19 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160719101454epcas1p34f5d8e05bd3fe8b8d229795b6626332b@epcas1p3.samsung.com>
2016-07-19 10:14 ` [U-Boot] [PATCH] mmc: fix the output format Ziyuan Xu
2016-07-19 10:35 ` Jaehoon Chung [this message]
2016-07-19 13:56 ` Ziyuan Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578E0278.20407@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox