From: Sinan Akman <sinan@writeme.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mpc83xx: fix the corruption of u-boot when saveenv
Date: Tue, 19 Jul 2016 23:55:11 -0400 [thread overview]
Message-ID: <578EF61F.5030909@writeme.com> (raw)
In-Reply-To: <AM4PR0401MB17322134DAA1266B63CA49039A370@AM4PR0401MB1732.eurprd04.prod.outlook.com>
Hi York
york sun wrote:
> On 07/08/2016 12:19 AM, Kevin Hao wrote:
>> Robert P. J. Day has pointed that the value of SYS_MONITOR_LEN in
>> MPC8315ERDB.h is smaller than the u-boot.bin. This will cause the
>> overlap between the code of u-boot and the environment variable.
>> So when executing saveenv, it will corrupt the code of u-boot and
>> causes the board not boot. Fix this for all the mpc83xx boards by
>> reserving a 512K area.
>>
>> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
>> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
>> ---
>> include/configs/MPC8308RDB.h | 2 +-
>> include/configs/MPC8313ERDB.h | 2 +-
>> include/configs/MPC8315ERDB.h | 2 +-
>> include/configs/MPC8323ERDB.h | 2 +-
>> include/configs/MPC832XEMDS.h | 2 +-
>> include/configs/MPC8349EMDS.h | 2 +-
>> include/configs/MPC8349ITX.h | 2 +-
>> include/configs/MPC837XEMDS.h | 2 +-
>> include/configs/MPC837XERDB.h | 2 +-
>> 9 files changed, 9 insertions(+), 9 deletions(-)
>>
>
> I don't have any mpc83xx board to test the change. But it looks OK.
>
> Sinan, do you have any comment for this and next patch in this set?
I am travelling now but I could test several MPC83xx boards sometimes
next week if you prefer to wait for test. Otherwise the patch looks fine.
Regards
Sinan Akman
next prev parent reply other threads:[~2016-07-20 3:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 3:25 [U-Boot] [PATCH 0/2] mpc83xx: fix the broken on the mpc83xx boards Kevin Hao
2016-07-08 3:25 ` [U-Boot] [PATCH 1/2] mpc83xx: fix the corruption of u-boot when saveenv Kevin Hao
2016-07-19 22:32 ` york sun
2016-07-20 3:55 ` Sinan Akman [this message]
2016-07-08 3:25 ` [U-Boot] [PATCH 2/2] mpc83xx: make it bootable with the latest kernel Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578EF61F.5030909@writeme.com \
--to=sinan@writeme.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox