From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Akman Date: Tue, 19 Jul 2016 23:55:11 -0400 Subject: [U-Boot] [PATCH 1/2] mpc83xx: fix the corruption of u-boot when saveenv In-Reply-To: References: <1467948315-176376-1-git-send-email-kexin.hao@windriver.com> <1467948315-176376-2-git-send-email-kexin.hao@windriver.com> Message-ID: <578EF61F.5030909@writeme.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi York york sun wrote: > On 07/08/2016 12:19 AM, Kevin Hao wrote: >> Robert P. J. Day has pointed that the value of SYS_MONITOR_LEN in >> MPC8315ERDB.h is smaller than the u-boot.bin. This will cause the >> overlap between the code of u-boot and the environment variable. >> So when executing saveenv, it will corrupt the code of u-boot and >> causes the board not boot. Fix this for all the mpc83xx boards by >> reserving a 512K area. >> >> Reported-by: Robert P. J. Day >> Signed-off-by: Kevin Hao >> --- >> include/configs/MPC8308RDB.h | 2 +- >> include/configs/MPC8313ERDB.h | 2 +- >> include/configs/MPC8315ERDB.h | 2 +- >> include/configs/MPC8323ERDB.h | 2 +- >> include/configs/MPC832XEMDS.h | 2 +- >> include/configs/MPC8349EMDS.h | 2 +- >> include/configs/MPC8349ITX.h | 2 +- >> include/configs/MPC837XEMDS.h | 2 +- >> include/configs/MPC837XERDB.h | 2 +- >> 9 files changed, 9 insertions(+), 9 deletions(-) >> > > I don't have any mpc83xx board to test the change. But it looks OK. > > Sinan, do you have any comment for this and next patch in this set? I am travelling now but I could test several MPC83xx boards sometimes next week if you prefer to wait for test. Otherwise the patch looks fine. Regards Sinan Akman