From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Thu, 21 Jul 2016 10:46:46 +0200 Subject: [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting In-Reply-To: References: <1469043274-1816-1-git-send-email-breno.lima@nxp.com> Message-ID: <57908BF6.80606@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Breno, Stefan, Am 20.07.2016 um 21:44 schrieb Stefan Agner: > On 20.07.2016 12:34, Breno Lima wrote: >> Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver >> model") breaks the serial output for the imx boards that do not use >> the serial driver model. >> >> The reason for the breakage is that it's setting UFCR_DCEDTE >> unconditionally for the non-dm case. > Uh yes, that wasn't intentionally and slipped through review! I meant to > add DTE support only in the dm case. Sorry about that. > > Acked-by: Stefan Agner Right, I apply this before sending my PR to Tom. Best regards, Stefano Babic > >> So keep the original behavior by removing UFCR_DCEDTE setting in the >> non-dm case. >> >> Tested on mx7sabresd and mx6wandboard. >> >> Signed-off-by: Breno Lima >> --- >> drivers/serial/serial_mxc.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c >> index 1960bbc..8545714 100644 >> --- a/drivers/serial/serial_mxc.c >> +++ b/drivers/serial/serial_mxc.c >> @@ -151,7 +151,6 @@ static void mxc_serial_setbrg(void) >> __REG(UART_PHYS + UFCR) = (RFDIV << UFCR_RFDIV_SHF) >> | (TXTL << UFCR_TXTL_SHF) >> | (RXTL << UFCR_RXTL_SHF); >> - __REG(UART_PHYS + UFCR) |= UFCR_DCEDTE; >> __REG(UART_PHYS + UBIR) = 0xf; >> __REG(UART_PHYS + UBMR) = clk / (2 * gd->baudrate); >>