* [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting
@ 2016-07-20 19:34 Breno Lima
2016-07-20 19:44 ` Stefan Agner
2016-07-20 20:19 ` Fabio Estevam
0 siblings, 2 replies; 4+ messages in thread
From: Breno Lima @ 2016-07-20 19:34 UTC (permalink / raw)
To: u-boot
Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver
model") breaks the serial output for the imx boards that do not use
the serial driver model.
The reason for the breakage is that it's setting UFCR_DCEDTE
unconditionally for the non-dm case.
So keep the original behavior by removing UFCR_DCEDTE setting in the
non-dm case.
Tested on mx7sabresd and mx6wandboard.
Signed-off-by: Breno Lima <breno.lima@nxp.com>
---
drivers/serial/serial_mxc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
index 1960bbc..8545714 100644
--- a/drivers/serial/serial_mxc.c
+++ b/drivers/serial/serial_mxc.c
@@ -151,7 +151,6 @@ static void mxc_serial_setbrg(void)
__REG(UART_PHYS + UFCR) = (RFDIV << UFCR_RFDIV_SHF)
| (TXTL << UFCR_TXTL_SHF)
| (RXTL << UFCR_RXTL_SHF);
- __REG(UART_PHYS + UFCR) |= UFCR_DCEDTE;
__REG(UART_PHYS + UBIR) = 0xf;
__REG(UART_PHYS + UBMR) = clk / (2 * gd->baudrate);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting
2016-07-20 19:34 [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting Breno Lima
@ 2016-07-20 19:44 ` Stefan Agner
2016-07-21 8:46 ` stefano babic
2016-07-20 20:19 ` Fabio Estevam
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Agner @ 2016-07-20 19:44 UTC (permalink / raw)
To: u-boot
On 20.07.2016 12:34, Breno Lima wrote:
> Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver
> model") breaks the serial output for the imx boards that do not use
> the serial driver model.
>
> The reason for the breakage is that it's setting UFCR_DCEDTE
> unconditionally for the non-dm case.
Uh yes, that wasn't intentionally and slipped through review! I meant to
add DTE support only in the dm case. Sorry about that.
Acked-by: Stefan Agner <stefan.agner@toradex.com>
>
> So keep the original behavior by removing UFCR_DCEDTE setting in the
> non-dm case.
>
> Tested on mx7sabresd and mx6wandboard.
>
> Signed-off-by: Breno Lima <breno.lima@nxp.com>
> ---
> drivers/serial/serial_mxc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
> index 1960bbc..8545714 100644
> --- a/drivers/serial/serial_mxc.c
> +++ b/drivers/serial/serial_mxc.c
> @@ -151,7 +151,6 @@ static void mxc_serial_setbrg(void)
> __REG(UART_PHYS + UFCR) = (RFDIV << UFCR_RFDIV_SHF)
> | (TXTL << UFCR_TXTL_SHF)
> | (RXTL << UFCR_RXTL_SHF);
> - __REG(UART_PHYS + UFCR) |= UFCR_DCEDTE;
> __REG(UART_PHYS + UBIR) = 0xf;
> __REG(UART_PHYS + UBMR) = clk / (2 * gd->baudrate);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting
2016-07-20 19:44 ` Stefan Agner
@ 2016-07-21 8:46 ` stefano babic
0 siblings, 0 replies; 4+ messages in thread
From: stefano babic @ 2016-07-21 8:46 UTC (permalink / raw)
To: u-boot
Hi Breno, Stefan,
Am 20.07.2016 um 21:44 schrieb Stefan Agner:
> On 20.07.2016 12:34, Breno Lima wrote:
>> Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver
>> model") breaks the serial output for the imx boards that do not use
>> the serial driver model.
>>
>> The reason for the breakage is that it's setting UFCR_DCEDTE
>> unconditionally for the non-dm case.
> Uh yes, that wasn't intentionally and slipped through review! I meant to
> add DTE support only in the dm case. Sorry about that.
>
> Acked-by: Stefan Agner <stefan.agner@toradex.com>
Right, I apply this before sending my PR to Tom.
Best regards,
Stefano Babic
>
>> So keep the original behavior by removing UFCR_DCEDTE setting in the
>> non-dm case.
>>
>> Tested on mx7sabresd and mx6wandboard.
>>
>> Signed-off-by: Breno Lima <breno.lima@nxp.com>
>> ---
>> drivers/serial/serial_mxc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
>> index 1960bbc..8545714 100644
>> --- a/drivers/serial/serial_mxc.c
>> +++ b/drivers/serial/serial_mxc.c
>> @@ -151,7 +151,6 @@ static void mxc_serial_setbrg(void)
>> __REG(UART_PHYS + UFCR) = (RFDIV << UFCR_RFDIV_SHF)
>> | (TXTL << UFCR_TXTL_SHF)
>> | (RXTL << UFCR_RXTL_SHF);
>> - __REG(UART_PHYS + UFCR) |= UFCR_DCEDTE;
>> __REG(UART_PHYS + UBIR) = 0xf;
>> __REG(UART_PHYS + UBMR) = clk / (2 * gd->baudrate);
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting
2016-07-20 19:34 [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting Breno Lima
2016-07-20 19:44 ` Stefan Agner
@ 2016-07-20 20:19 ` Fabio Estevam
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-07-20 20:19 UTC (permalink / raw)
To: u-boot
On Wed, Jul 20, 2016 at 4:34 PM, Breno Lima <breno.lima@nxp.com> wrote:
> Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver
> model") breaks the serial output for the imx boards that do not use
> the serial driver model.
>
> The reason for the breakage is that it's setting UFCR_DCEDTE
> unconditionally for the non-dm case.
>
> So keep the original behavior by removing UFCR_DCEDTE setting in the
> non-dm case.
>
> Tested on mx7sabresd and mx6wandboard.
>
> Signed-off-by: Breno Lima <breno.lima@nxp.com>
Thanks for the fix:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-21 8:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-20 19:34 [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting Breno Lima
2016-07-20 19:44 ` Stefan Agner
2016-07-21 8:46 ` stefano babic
2016-07-20 20:19 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox