public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type
Date: Sat, 23 Jul 2016 11:11:57 +0800	[thread overview]
Message-ID: <5792E07D.7060105@rock-chips.com> (raw)
In-Reply-To: <57902F3F.6040508@samsung.com>

Hi Jaehoon,

Thanks for your catch, fix it in v3.

On 2016?07?21? 10:11, Jaehoon Chung wrote:
> Hi Ziyuan,
>
> On 07/19/2016 11:21 PM, Ziyuan Xu wrote:
>> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>>
>> It's nicer to see this:
>>
>> => mmc list
>> dwmmc at ff0c0000: 0
>> dwmmc at ff0f0000: 1 (eMMC)
>>
>> than this:
>>
>> => mmc list
>> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>>
>> With the latter, it's much clearer which mmc devices are on.
> Right? "With latter"?
>
>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>
>> Serise-changes: 2
>> - Update commit from Jaehoon
> Could you add the Changelog to the below line?
>
>> Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com>
>> ---
> Locate the Changelog at here.
>
> Best Regards,
> Jaehoon Chung
>
>>   drivers/mmc/mmc-uclass.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
>> index 38ced41..beebc70 100644
>> --- a/drivers/mmc/mmc-uclass.c
>> +++ b/drivers/mmc/mmc-uclass.c
>> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>>   
>>   	for (uclass_first_device(UCLASS_MMC, &dev);
>>   	     dev;
>> -	     uclass_next_device(&dev)) {
>> +	     uclass_next_device(&dev), first = false) {
>>   		struct mmc *m = mmc_get_mmc_dev(dev);
>>   
>>   		if (!first) {
>>
>
>
>

  reply	other threads:[~2016-07-23  3:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160719142140epcas1p11ff53d15c82f6182d02c2fb5604ed506@epcas1p1.samsung.com>
2016-07-19 14:21 ` [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
2016-07-21  2:11   ` Jaehoon Chung
2016-07-23  3:11     ` Ziyuan Xu [this message]
2016-07-22  3:21   ` Simon Glass
2016-07-23  2:57     ` Simon Glass
2016-07-23  3:12       ` Ziyuan Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5792E07D.7060105@rock-chips.com \
    --to=xzy.xu@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox