* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type @ 2016-07-19 14:21 ` Ziyuan Xu 2016-07-21 2:11 ` Jaehoon Chung 2016-07-22 3:21 ` Simon Glass 0 siblings, 2 replies; 6+ messages in thread From: Ziyuan Xu @ 2016-07-19 14:21 UTC (permalink / raw) To: u-boot From: Xu Ziyuan <xzy.xu@rock-chips.com> It's nicer to see this: => mmc list dwmmc at ff0c0000: 0 dwmmc at ff0f0000: 1 (eMMC) than this: => mmc list dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) With the latter, it's much clearer which mmc devices are on. Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> Serise-changes: 2 - Update commit from Jaehoon Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> --- drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator) for (uclass_first_device(UCLASS_MMC, &dev); dev; - uclass_next_device(&dev)) { + uclass_next_device(&dev), first = false) { struct mmc *m = mmc_get_mmc_dev(dev); if (!first) { -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type 2016-07-19 14:21 ` [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type Ziyuan Xu @ 2016-07-21 2:11 ` Jaehoon Chung 2016-07-23 3:11 ` Ziyuan Xu 2016-07-22 3:21 ` Simon Glass 1 sibling, 1 reply; 6+ messages in thread From: Jaehoon Chung @ 2016-07-21 2:11 UTC (permalink / raw) To: u-boot Hi Ziyuan, On 07/19/2016 11:21 PM, Ziyuan Xu wrote: > From: Xu Ziyuan <xzy.xu@rock-chips.com> > > It's nicer to see this: > > => mmc list > dwmmc at ff0c0000: 0 > dwmmc at ff0f0000: 1 (eMMC) > > than this: > > => mmc list > dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) > > With the latter, it's much clearer which mmc devices are on. Right? "With latter"? > > Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > > Serise-changes: 2 > - Update commit from Jaehoon Could you add the Changelog to the below line? > > Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> > --- Locate the Changelog at here. Best Regards, Jaehoon Chung > > drivers/mmc/mmc-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c > index 38ced41..beebc70 100644 > --- a/drivers/mmc/mmc-uclass.c > +++ b/drivers/mmc/mmc-uclass.c > @@ -169,7 +169,7 @@ void print_mmc_devices(char separator) > > for (uclass_first_device(UCLASS_MMC, &dev); > dev; > - uclass_next_device(&dev)) { > + uclass_next_device(&dev), first = false) { > struct mmc *m = mmc_get_mmc_dev(dev); > > if (!first) { > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type 2016-07-21 2:11 ` Jaehoon Chung @ 2016-07-23 3:11 ` Ziyuan Xu 0 siblings, 0 replies; 6+ messages in thread From: Ziyuan Xu @ 2016-07-23 3:11 UTC (permalink / raw) To: u-boot Hi Jaehoon, Thanks for your catch, fix it in v3. On 2016?07?21? 10:11, Jaehoon Chung wrote: > Hi Ziyuan, > > On 07/19/2016 11:21 PM, Ziyuan Xu wrote: >> From: Xu Ziyuan <xzy.xu@rock-chips.com> >> >> It's nicer to see this: >> >> => mmc list >> dwmmc at ff0c0000: 0 >> dwmmc at ff0f0000: 1 (eMMC) >> >> than this: >> >> => mmc list >> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) >> >> With the latter, it's much clearer which mmc devices are on. > Right? "With latter"? > >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >> >> Serise-changes: 2 >> - Update commit from Jaehoon > Could you add the Changelog to the below line? > >> Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> >> --- > Locate the Changelog at here. > > Best Regards, > Jaehoon Chung > >> drivers/mmc/mmc-uclass.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c >> index 38ced41..beebc70 100644 >> --- a/drivers/mmc/mmc-uclass.c >> +++ b/drivers/mmc/mmc-uclass.c >> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator) >> >> for (uclass_first_device(UCLASS_MMC, &dev); >> dev; >> - uclass_next_device(&dev)) { >> + uclass_next_device(&dev), first = false) { >> struct mmc *m = mmc_get_mmc_dev(dev); >> >> if (!first) { >> > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type 2016-07-19 14:21 ` [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type Ziyuan Xu 2016-07-21 2:11 ` Jaehoon Chung @ 2016-07-22 3:21 ` Simon Glass 2016-07-23 2:57 ` Simon Glass 1 sibling, 1 reply; 6+ messages in thread From: Simon Glass @ 2016-07-22 3:21 UTC (permalink / raw) To: u-boot On 19 July 2016 at 08:21, Ziyuan Xu <xzy.xu@rock-chips.com> wrote: > From: Xu Ziyuan <xzy.xu@rock-chips.com> > > It's nicer to see this: > > => mmc list > dwmmc at ff0c0000: 0 > dwmmc at ff0f0000: 1 (eMMC) > > than this: > > => mmc list > dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) > > With the latter, it's much clearer which mmc devices are on. > > Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > > Serise-changes: 2 > - Update commit from Jaehoon > > Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> > --- > > drivers/mmc/mmc-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the bug fix. Acked-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type 2016-07-22 3:21 ` Simon Glass @ 2016-07-23 2:57 ` Simon Glass 2016-07-23 3:12 ` Ziyuan Xu 0 siblings, 1 reply; 6+ messages in thread From: Simon Glass @ 2016-07-23 2:57 UTC (permalink / raw) To: u-boot Hi, On 21 July 2016 at 21:21, Simon Glass <sjg@chromium.org> wrote: > On 19 July 2016 at 08:21, Ziyuan Xu <xzy.xu@rock-chips.com> wrote: >> From: Xu Ziyuan <xzy.xu@rock-chips.com> >> >> It's nicer to see this: >> >> => mmc list >> dwmmc at ff0c0000: 0 >> dwmmc at ff0f0000: 1 (eMMC) >> >> than this: >> >> => mmc list >> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) >> >> With the latter, it's much clearer which mmc devices are on. >> >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >> >> Serise-changes: 2 >> - Update commit from Jaehoon >> >> Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> >> --- >> >> drivers/mmc/mmc-uclass.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for the bug fix. > > Acked-by: Simon Glass <sjg@chromium.org> Please can you send a v2 with the nits fixed? - Simon ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type 2016-07-23 2:57 ` Simon Glass @ 2016-07-23 3:12 ` Ziyuan Xu 0 siblings, 0 replies; 6+ messages in thread From: Ziyuan Xu @ 2016-07-23 3:12 UTC (permalink / raw) To: u-boot Hi Simon, On 2016?07?23? 10:57, Simon Glass wrote: > Hi, > > On 21 July 2016 at 21:21, Simon Glass <sjg@chromium.org> wrote: >> On 19 July 2016 at 08:21, Ziyuan Xu <xzy.xu@rock-chips.com> wrote: >>> From: Xu Ziyuan <xzy.xu@rock-chips.com> >>> >>> It's nicer to see this: >>> >>> => mmc list >>> dwmmc at ff0c0000: 0 >>> dwmmc at ff0f0000: 1 (eMMC) >>> >>> than this: >>> >>> => mmc list >>> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC) >>> >>> With the latter, it's much clearer which mmc devices are on. >>> >>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >>> >>> Serise-changes: 2 >>> - Update commit from Jaehoon >>> >>> Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com> >>> --- >>> >>> drivers/mmc/mmc-uclass.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> Thanks for the bug fix. >> >> Acked-by: Simon Glass <sjg@chromium.org> > Please can you send a v2 with the nits fixed? Fixed, see v3. > > - Simon > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-23 3:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160719142140epcas1p11ff53d15c82f6182d02c2fb5604ed506@epcas1p1.samsung.com>
2016-07-19 14:21 ` [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
2016-07-21 2:11 ` Jaehoon Chung
2016-07-23 3:11 ` Ziyuan Xu
2016-07-22 3:21 ` Simon Glass
2016-07-23 2:57 ` Simon Glass
2016-07-23 3:12 ` Ziyuan Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox