From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ziyuan Xu Date: Sat, 23 Jul 2016 11:45:07 +0800 Subject: [U-Boot] [PATCH] Revert "rockchip: Move the MMC setup check earlier" In-Reply-To: References: <1468894407-26770-1-git-send-email-xzy.xu@rock-chips.com> Message-ID: <5792E843.6000706@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 2016?07?23? 10:57, Simon Glass wrote: > On 18 July 2016 at 20:13, Ziyuan Xu wrote: >> Boot Rom wouldn't initialize sdmmc while booting from eMMC. We need to >> setup sdmmc gpio, otherwise we will hit an error below: >> >> =>mmc info >> blk_get_device: if_type=6, devnum=0: dwmmc at ff0c0000.blk, 6, 0 >> uclass_find_device_by_seq: 0 -1 >> uclass_find_device_by_seq: 0 0 >> - -1 -1 >> - -1 0 >> - found >> uclass_find_device_by_seq: 0 1 >> - -1 -1 >> - -1 0 >> - not found >> fdtdec_get_int_array: interrupts >> get_prop_check_min_len: interrupts >> Buswidth = 1, clock: 0 >> Buswidth = 1, clock: 400000 >> Sending CMD0 >> dwmci_send_cmd: Timeout on data busy >> dwmci_send_cmd: Timeout on data busy >> dwmci_send_cmd: Timeout on data busy >> dwmci_send_cmd: Timeout on data busy >> >> This reverts commit 6efeeea79c880d3dd262e0dca9da2687f0ab68c9. >> >> Signed-off-by: Ziyuan Xu >> --- >> >> arch/arm/mach-rockchip/rk3288-board-spl.c | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) > Acked-by: Simon Glass > Tested on firefly-rk3288: > Tested-by: Simon Glass > > I think this is safe to apply now that we have reduced SPL size. Did you mean that commit 97feca3325bb2065a7ef7d30e1f308b74f1fb33c(rockchip: Use of-platdata for firefly-rk3288)? If you recommend that use of-platfdata instead of of-libfd, I will revise it on evb-rk32288 & fennect-rk3288 board. > > - Simon > > >