* [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type
@ 2016-07-23 3:11 Ziyuan Xu
2016-07-25 2:07 ` Simon Glass
2016-08-05 2:26 ` [U-Boot] [U-Boot, " Jaehoon Chung
0 siblings, 2 replies; 4+ messages in thread
From: Ziyuan Xu @ 2016-07-23 3:11 UTC (permalink / raw)
To: u-boot
From: Xu Ziyuan <xzy.xu@rock-chips.com>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
---
Changes in v3:
- Fix nits
Changes in v2:
- Update commit from Jaehoon
drivers/mmc/mmc-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index 38ced41..beebc70 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev);
dev;
- uclass_next_device(&dev)) {
+ uclass_next_device(&dev), first = false) {
struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type
2016-07-23 3:11 [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
@ 2016-07-25 2:07 ` Simon Glass
2016-07-25 4:58 ` Jaehoon Chung
2016-08-05 2:26 ` [U-Boot] [U-Boot, " Jaehoon Chung
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2016-07-25 2:07 UTC (permalink / raw)
To: u-boot
On 22 July 2016 at 21:11, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>
> It's nicer to see this:
>
> => mmc list
> dwmmc at ff0c0000: 0
> dwmmc at ff0f0000: 1 (eMMC)
>
> than this:
>
> => mmc list
> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>
> With the former, it's much clearer which mmc devices are on.
>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>
> ---
>
> Changes in v3:
> - Fix nits
>
> Changes in v2:
> - Update commit from Jaehoon
>
> drivers/mmc/mmc-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type
2016-07-25 2:07 ` Simon Glass
@ 2016-07-25 4:58 ` Jaehoon Chung
0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2016-07-25 4:58 UTC (permalink / raw)
To: u-boot
On 07/25/2016 11:07 AM, Simon Glass wrote:
> On 22 July 2016 at 21:11, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>>
>> It's nicer to see this:
>>
>> => mmc list
>> dwmmc at ff0c0000: 0
>> dwmmc at ff0f0000: 1 (eMMC)
>>
>> than this:
>>
>> => mmc list
>> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>>
>> With the former, it's much clearer which mmc devices are on.
>>
>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>
>> ---
>>
>> Changes in v3:
>> - Fix nits
>>
>> Changes in v2:
>> - Update commit from Jaehoon
>>
>> drivers/mmc/mmc-uclass.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, v3] mmc: display mmc list information like mmc_legacy type
2016-07-23 3:11 [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
2016-07-25 2:07 ` Simon Glass
@ 2016-08-05 2:26 ` Jaehoon Chung
1 sibling, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2016-08-05 2:26 UTC (permalink / raw)
To: u-boot
On 07/23/2016 12:11 PM, Xu Ziyuan wrote:
> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>
> It's nicer to see this:
>
> => mmc list
> dwmmc at ff0c0000: 0
> dwmmc at ff0f0000: 1 (eMMC)
>
> than this:
>
> => mmc list
> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>
> With the former, it's much clearer which mmc devices are on.
>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied on u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
> ---
>
> Changes in v3:
> - Fix nits
>
> Changes in v2:
> - Update commit from Jaehoon
>
> drivers/mmc/mmc-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 38ced41..beebc70 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>
> for (uclass_first_device(UCLASS_MMC, &dev);
> dev;
> - uclass_next_device(&dev)) {
> + uclass_next_device(&dev), first = false) {
> struct mmc *m = mmc_get_mmc_dev(dev);
>
> if (!first) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-05 2:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-23 3:11 [U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
2016-07-25 2:07 ` Simon Glass
2016-07-25 4:58 ` Jaehoon Chung
2016-08-05 2:26 ` [U-Boot] [U-Boot, " Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox