From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] i2c: i2c-uclass-compat: avoid any BSS usage
Date: Tue, 26 Jul 2016 08:23:30 +0200 [thread overview]
Message-ID: <579701E2.8050401@denx.de> (raw)
In-Reply-To: <20160725105645.27308-1-vigneshr@ti.com>
Hello Vignesh,
Am 25.07.2016 um 12:56 schrieb Vignesh R:
> As I2C can be used before DRAM initialization for reading EEPROM,
> avoid using static variables stored in BSS, since BSS is in DRAM, which
> may not have been initialised yet. Explicitly mark "static global"
> variables as belonging to the .data section.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/i2c/i2c-uclass-compat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Heiko Schocher<hs@denx.de>
bye,
Heiko
>
> diff --git a/drivers/i2c/i2c-uclass-compat.c b/drivers/i2c/i2c-uclass-compat.c
> index 5606d1f807f6..de78db6a887f 100644
> --- a/drivers/i2c/i2c-uclass-compat.c
> +++ b/drivers/i2c/i2c-uclass-compat.c
> @@ -9,7 +9,7 @@
> #include <errno.h>
> #include <i2c.h>
>
> -static int cur_busnum;
> +static int cur_busnum __attribute__((section(".data")));
>
> static int i2c_compat_get_device(uint chip_addr, int alen,
> struct udevice **devp)
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-07-26 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:56 [U-Boot] [RFC PATCH] i2c: i2c-uclass-compat: avoid any BSS usage Vignesh R
2016-07-26 6:23 ` Heiko Schocher [this message]
2016-07-28 5:54 ` Vignesh R
2016-07-29 3:37 ` Heiko Schocher
2016-08-01 1:03 ` Simon Glass
2016-08-10 0:45 ` [U-Boot] [U-Boot, RFC] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579701E2.8050401@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox