From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/30] x86: Add debugging when a microcode update fails
Date: Wed, 27 Jul 2016 06:22:02 +0200 [thread overview]
Message-ID: <579836EA.8070109@denx.de> (raw)
In-Reply-To: <1469494766-26601-2-git-send-email-sjg@chromium.org>
Hello Simon,
Am 26.07.2016 um 02:58 schrieb Simon Glass:
> Add a debug() at this point to help figure out what is wrong.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> arch/x86/cpu/intel_common/cpu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Heiko Schocher<hs@denx.de>
but wondering why this is in the "binman: A tool for creating firmware images"
series.
bye,
Heiko
>
> diff --git a/arch/x86/cpu/intel_common/cpu.c b/arch/x86/cpu/intel_common/cpu.c
> index 0fdef6f..ae42095 100644
> --- a/arch/x86/cpu/intel_common/cpu.c
> +++ b/arch/x86/cpu/intel_common/cpu.c
> @@ -42,8 +42,10 @@ int cpu_common_init(void)
> enable_lapic();
>
> ret = microcode_update_intel();
> - if (ret && ret != -EEXIST)
> + if (ret && ret != -EEXIST) {
> + debug("%s: Microcode update failure (err=%d)\n", __func__, ret);
> return ret;
> + }
>
> /* Enable upper 128bytes of CMOS */
> writel(1 << 2, RCB_REG(RC));
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-07-27 4:22 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 0:58 [U-Boot] [PATCH 00/30] binman: A tool for creating firmware images Simon Glass
2016-07-26 0:58 ` [U-Boot] [PATCH 01/30] x86: Add debugging when a microcode update fails Simon Glass
2016-07-27 4:22 ` Heiko Schocher [this message]
2016-07-28 6:53 ` Bin Meng
2016-08-29 1:45 ` Bin Meng
2016-07-26 0:58 ` [U-Boot] [PATCH 02/30] x86: ivybridge: Allow microcode to be collated Simon Glass
2016-07-28 6:53 ` Bin Meng
2016-08-29 1:45 ` Bin Meng
2016-07-26 0:58 ` [U-Boot] [PATCH 03/30] x86: Add debugging when cpu_common_init() fails Simon Glass
2016-07-28 6:53 ` Bin Meng
2016-08-29 1:45 ` Bin Meng
2016-07-26 0:59 ` [U-Boot] [PATCH 04/30] patman: Adjust command.Output() to raise an error by default Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 05/30] dtoc: Move the struct import into the correct order Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 06/30] dtoc: Move the fdt library selection into fdt_select Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 07/30] dtoc: Rename fdt.py to fdt_normal.py Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 08/30] dtoc: Create a base class for Fdt Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 09/30] dtoc: Move BytesToValue() and GetEmpty() into PropBase Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 10/30] dtoc: Move Widen() and GetPhandle() into the base class Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 11/30] dtoc: Move a few more common functions into fdt.py Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 12/30] patman: Add a tools library for using temporary files Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 13/30] patman: Add a library to handle logging and progress Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 14/30] dtoc: Allow the device tree to be compiled from source Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 15/30] dtoc: Drop the convert_dash parameter to GetProps() Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 16/30] dtoc: Prepare for supporting changing of device trees Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 17/30] dtoc: Move to using bytearray Simon Glass
2016-08-27 16:05 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 18/30] dtoc: Support deleting device tree properties Simon Glass
2016-08-27 16:06 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 19/30] dtoc: Support packing the device tree Simon Glass
2016-08-27 16:06 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 20/30] dtoc: Support finding the offset of a property Simon Glass
2016-08-27 16:06 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 21/30] dtoc: Correct quotes in fdt_util Simon Glass
2016-08-27 16:06 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 22/30] dtoc: Add methods for reading data from properties Simon Glass
2016-08-27 16:06 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 23/30] binman: Introduce binman, a tool for building binary images Simon Glass
2016-07-27 4:59 ` Heiko Schocher
2016-07-26 0:59 ` [U-Boot] [PATCH 24/30] binman: Add basic entry types for U-Boot Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 25/30] binman: Add support for building x86 ROMs Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 26/30] binman: Add support for u-boot.img as an input binary Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 27/30] binman: Add a build rule for binman Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 28/30] binman: Allow configuration options to be used in .dts files Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 29/30] RFC: Use binman for a sunxi board Simon Glass
2016-07-26 13:35 ` Ian Campbell
2016-07-26 23:49 ` Simon Glass
2016-07-26 0:59 ` [U-Boot] [PATCH 30/30] RFC: Use binman for an x86 board Simon Glass
2016-08-27 15:28 ` [U-Boot] [PATCH 00/30] binman: A tool for creating firmware images Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579836EA.8070109@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox