From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mmc: sdhci: set to INT_DATA_END when there are data
Date: Wed, 27 Jul 2016 14:11:05 +0900 [thread overview]
Message-ID: <57984269.7090001@samsung.com> (raw)
In-Reply-To: <CAAGaQKB57H6XDoBd66tLLVjnR9mf2KXtHVHe9TUqPaNLeivKkg@mail.gmail.com>
Hi
On 07/27/2016 01:10 AM, Steve Rae wrote:
> HI Lukasz,
>
> On Tue, Jul 26, 2016 at 2:13 AM, Lukasz Majewski <l.majewski@samsung.com> wrote:
>> Hi Steve,
>>
>>> with this change, I can also set the following back to 100:
>>>
>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
>>> index de8d8ea..d593dc6 100644
>>> --- a/drivers/mmc/sdhci.c
>>> +++ b/drivers/mmc/sdhci.c
>>> @@ -128,7 +128,7 @@ static int sdhci_transfer_data(struct sdhci_host
>>> *host, struct mmc_data *data,
>>> #define CONFIG_SDHCI_CMD_MAX_TIMEOUT 3200
>>> #endif
>>> #define CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT 100
>>> -#define SDHCI_READ_STATUS_TIMEOUT 1000
>>> +#define SDHCI_READ_STATUS_TIMEOUT 100
>>>
>>> #ifdef CONFIG_DM_MMC_OPS
>>> static int sdhci_send_command(struct udevice *dev, struct mmc_cmd
>>> *cmd,
>>>
>>> And it still works on my board ! Thanks !
>>
>> Could you prepare proper revert patch?
>>
>> --
>> Best regards,
>>
>> Lukasz Majewski
>>
>> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
>
> Looking at the code, I don't think there is any value changing the
> SDHCI_READ_STATUS_TIMEOUT from 1000 to 100.
> But maybe someone (Jaehoon ?) could comment on the impact of this
> SDHCI_READ_STATUS_TIMEOUT value in the SDHCI_QUIRK_BROKEN_R1B case...
> Does it affect performance in anyway?
There is no performance effect whatever SDHCI_READ_STATUS_TIMEOUT is using value.
So i think that we don't need to revert it..
SDHCI_QUIRK_BROKEN_R1B had been added from me.
At that time, i didn't know why added SDHCI_INT_DAT_END.
I'm not sure but if remove the SDHCI_INT_DAT_END,
I guess that SDHCI_QUIRK_BROKEN_R1B can be also removed.
(quirks is workaround flags, so if it can be removed, it's best.)
In future, I want to remove SDHCI_QUIRK_BROKEN_R1B.
Best Regards,
Jaehoon Chung
> If it does, the I'll prepare a patch....
>
> Thanks, Steve
>
>
>
next prev parent reply other threads:[~2016-07-27 5:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:18 [U-Boot] [PATCH 1/2] mmc: sdhci: set to INT_DATA_END when there are data Jaehoon Chung
2016-07-12 12:18 ` [U-Boot] [PATCH 2/2] mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B Jaehoon Chung
2016-07-12 12:55 ` Lukasz Majewski
2016-08-05 2:24 ` [U-Boot] [U-Boot, " Jaehoon Chung
2016-07-12 12:55 ` [U-Boot] [PATCH 1/2] mmc: sdhci: set to INT_DATA_END when there are data Lukasz Majewski
2016-07-25 4:55 ` Jaehoon Chung
2016-07-25 10:10 ` Minkyu Kang
2016-07-25 10:21 ` Lukasz Majewski
2016-07-25 23:23 ` Steve Rae
2016-07-25 23:28 ` Steve Rae
2016-07-26 9:13 ` Lukasz Majewski
2016-07-26 16:10 ` Steve Rae
2016-07-27 5:11 ` Jaehoon Chung [this message]
2016-08-01 10:05 ` Lukasz Majewski
2016-08-05 2:24 ` [U-Boot] [U-Boot, " Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57984269.7090001@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox