public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: send CMD0 before CMD1 for some MMC cards
Date: Wed, 27 Jul 2016 20:15:48 +0900	[thread overview]
Message-ID: <579897E4.2030207@samsung.com> (raw)
In-Reply-To: <HE1PR04MB0889E87B7CD7546C9EA00CBFF80F0@HE1PR04MB0889.eurprd04.prod.outlook.com>

On 07/27/2016 04:28 PM, Yangbo Lu wrote:
> Hi Tom,
> 
> Could you help to assign this mmc patch reviewing to right person?
> It seems no one had reviewed it for almost half year.
> 
> And another my mmc patch also needs to be reviewed.
> I submitted in May. Please help.
> http://patchwork.ozlabs.org/patch/624448/
> 
> 
> Thank you very much.
> 
> 
> Best regards,
> Yangbo Lu
> 
>> -----Original Message-----
>> From: Yangbo Lu [mailto:yangbo.lu at nxp.com]
>> Sent: Wednesday, March 09, 2016 11:00 AM
>> To: u-boot at lists.denx.de
>> Cc: Pantelis Antoniou; Yangbo Lu
>> Subject: [PATCH] mmc: send CMD0 before CMD1 for some MMC cards
>>
>> When the MMC framework was added in u-boot, the mmc_go_idle was added
>> before mmc_send_op_cond_iter in function mmc_send_op_cond annotating that
>> some cards seemed to need this. Actually, we still need to do this in
>> function mmc_complete_op_cond for those cards.
>> This has been verified on Micron MTFC4GACAECN eMMC chip.

If there is no go_idle(), then what happen?
If you share the information more, i can check the more..

Best Regards,
Jaehoon Chung

>>
>> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
>> ---
>>  drivers/mmc/mmc.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index ede5d6e..82e3268
>> 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -418,6 +418,9 @@ static int mmc_complete_op_cond(struct mmc *mmc)
>>  	uint start;
>>  	int err;
>>
>> +	/* Some cards seem to need this */
>> +	mmc_go_idle(mmc);
>> +
>>  	mmc->op_cond_pending = 0;
>>  	if (!(mmc->ocr & OCR_BUSY)) {
>>  		start = get_timer(0);
>> --
>> 2.1.0.27.g96db324
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 
> 

  reply	other threads:[~2016-07-27 11:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  3:00 [U-Boot] [PATCH] mmc: send CMD0 before CMD1 for some MMC cards Yangbo Lu
2016-04-21  0:38 ` Yangbo Lu
2016-07-27  7:28 ` Yangbo Lu
2016-07-27 11:15   ` Jaehoon Chung [this message]
2016-07-27 13:37     ` Ziyuan Xu
2016-07-28  2:45       ` Yangbo Lu
2016-07-28  8:39         ` Jaehoon Chung
2016-08-02  7:03           ` Yangbo Lu
2016-08-02  7:13             ` Jaehoon Chung
2016-08-02  7:16               ` Yangbo Lu
2016-08-02  7:18               ` Jaehoon Chung
2016-08-02  7:23                 ` Yangbo Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579897E4.2030207@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox