public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 00/42] Kconfig: Move CONFIG_SPL_..._SUPPORT to Kconfig
Date: Thu, 25 Aug 2016 06:30:52 +0200	[thread overview]
Message-ID: <57BE747C.2080603@denx.de> (raw)
In-Reply-To: <1472057546-10360-1-git-send-email-sjg@chromium.org>

Hello Simon,

Am 24.08.2016 um 18:51 schrieb Simon Glass:
> This series moves all the CONFIG_SPL_..._SUPPORT options to Kconfig and
> fixes up existing boards to continue to build.
 >
> It also adds a few small but useful features to moveconfig.
>
> There is existing work going on in this area, so some of these patches may
> be superseded. It has taken me a while to get this building cleanly. But I
> have run out of time so want to get this out.
>
> As mentioned on a recent thread [1] there is some confusion about whether an
> option means enabling driver support or media support. Andrew's recent
> series seems like a good vehicle to tidy that up. But I hope this series
> will make it easier.
>
> There are a few strange features of this conversion. The main difficulty is
> that some PowerPC boards do things like this in their board config file:
>
>   #ifdef CONFIG_TPL_BUILD
>   #define CONFIG_SPL_SERIAL_SUPPORT
>   #define CONFIG_SPL_ENV_SUPPORT
>   #else
>   #define CONFIG_SPL_SERIAL_SUPPORT
>   #endif
>
> This means that TPL reuses the SPL options. We can't support this in Kconfig
> so I have added a small number of CONFIG_TPL_xxx_SUPPORT options to cope
> with this. This made the conversion more painful than it should have been.
>
> A related issue is boards using a common header file and setting options only
> for SPL:
>
>   #ifdef CONFIG_SPL_BUILD
>   #define CONFIG_SPL_SERIAL_SUPPORT
>   #endif
>
> This is not noticed by moveconfig so we have to clean it up manually. Also
> there are a few incorrect things where Kconfig options are set with #define:
>
>   #ifdef CONFIG_SPL_BUILD
>   #define CONFIG_SPL_DM
>   #endif
>
> Finally, many defconfig files are not ordered correctly, resulting in larger
> patches than we might like. It would be great to have a solution for this,
> perhaps with buildman providing a warning. But it might slow down
> development.
>
> The series is fully build-tested (for bisectability) and causes no failures
> for the boards that already pass. The following boards fail for me at
> present on mainline (which I have not yet looked at):

Thanks!

Hmm... may you want to check, if your patchserie does not
break any existing board? I wrote a tbot testcase for this, see:

http://lists.denx.de/pipermail/u-boot/2016-June/258119.html

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2016-08-25  4:30 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 16:51 [U-Boot] [PATCH 00/42] Kconfig: Move CONFIG_SPL_..._SUPPORT to Kconfig Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 01/42] moveconfig: Add an option to skip prompts Simon Glass
2016-08-25  1:45   ` Masahiro Yamada
2016-08-25 12:04     ` Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 02/42] moveconfig: Add an option to commit changes Simon Glass
2016-08-25  1:40   ` Masahiro Yamada
2016-08-25 12:04     ` Simon Glass
2016-08-26 16:47       ` Masahiro Yamada
2016-08-26 18:13         ` Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 03/42] Kconfig: Move SPL settings into their own file Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 04/42] arm: fsl: Adjust ordering of #ifndef CONFIG_SPL_BUILD Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 05/42] Drop CONFIG_SPL_RAM_SUPPORT Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 06/42] Use separate options for TPL support Simon Glass
2016-08-24 18:16   ` Stephen Warren
2016-08-25  0:41     ` Tom Rini
2016-08-25 12:04     ` Simon Glass
2016-08-25  2:20   ` Masahiro Yamada
2016-08-25 12:04     ` Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 07/42] Kconfig: spl: Add SPL support options to Kconfig Simon Glass
2016-08-25  1:28   ` Masahiro Yamada
2016-08-25 12:04     ` Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 08/42] Kconfig: tpl: Add some TPL " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 09/42] Move existing use of CONFIG_SPL_DM " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 10/42] Move existing use of CONFIG_SPL_RSA " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 11/42] Convert CONFIG_SPL_CRYPTO_SUPPORT " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 12/42] Convert CONFIG_SPL_HASH_SUPPORT " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 13/42] Convert CONFIG_SPL_DMA_SUPPORT " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 14/42] Convert CONFIG_SPL_DRIVERS_MISC_SUPPORT " Simon Glass
2016-08-24 16:51 ` [U-Boot] [PATCH 15/42] Convert CONFIG_SPL_ENV_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 16/42] Convert CONFIG_SPL_ETH_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 17/42] Convert CONFIG_SPL_EXT_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 18/42] Convert CONFIG_SPL_FAT_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 19/42] Convert CONFIG_SPL_GPIO_SUPPORT " Simon Glass
2016-08-24 18:01   ` Maxime Ripard
2016-08-24 19:30     ` Tom Rini
2016-08-25 12:04       ` Simon Glass
2016-08-25 22:01         ` Tom Rini
2016-08-26  2:14           ` Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 20/42] Convert CONFIG_SPL_I2C_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 21/42] Convert CONFIG_SPL_LIBCOMMON_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 22/42] Convert CONFIG_SPL_LIBDISK_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 23/42] Convert CONFIG_SPL_LIBGENERIC_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 24/42] Convert CONFIG_SPL_MMC_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 25/42] Convert CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 26/42] Convert CONFIG_SPL_MTD_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 27/42] Convert CONFIG_SPL_MUSB_NEW_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 28/42] Convert CONFIG_SPL_NAND_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 29/42] Convert CONFIG_SPL_NET_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 30/42] Convert CONFIG_SPL_NOR_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 31/42] Convert CONFIG_SPL_ONENAND_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 32/42] Convert CONFIG_SPL_PINCTRL_SUPPORT " Simon Glass
2016-08-25  1:34   ` Masahiro Yamada
2016-08-25 12:04     ` Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 33/42] Convert CONFIG_SPL_POWER_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 34/42] Convert CONFIG_SPL_SATA_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 35/42] Convert CONFIG_SPL_SERIAL_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 36/42] Convert CONFIG_SPL_SPI_FLASH_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 37/42] Convert CONFIG_SPL_SPI_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 38/42] Convert CONFIG_SPL_USBETH_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 39/42] Convert CONFIG_SPL_USB_HOST_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 40/42] Convert CONFIG_SPL_USB_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 41/42] Convert CONFIG_SPL_WATCHDOG_SUPPORT " Simon Glass
2016-08-24 16:52 ` [U-Boot] [PATCH 42/42] Convert CONFIG_SPL_YMODEM_SUPPORT " Simon Glass
2016-08-25  4:30 ` Heiko Schocher [this message]
2016-08-25 12:04   ` [U-Boot] [PATCH 00/42] Kconfig: Move CONFIG_SPL_..._SUPPORT " Simon Glass
2016-08-26  4:58     ` Heiko Schocher
2016-08-25 14:19 ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BE747C.2080603@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox