* [U-Boot] [PATCH] sf: fix sf probe
@ 2016-08-17 7:19 Wenyou Yang
2016-08-25 11:13 ` Stefan Roese
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wenyou Yang @ 2016-08-17 7:19 UTC (permalink / raw)
To: u-boot
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
This patch fixes the "sf probe" command. The very first SPI flash probe
passes, for instance when u-boot tries to read its environment settings
from a (Q)SPI memory but next "sf probe" commands fail because the flash
memory node is unbound from the SPI controller children nodes.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
cmd/sf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/cmd/sf.c b/cmd/sf.c
index 286906c..65b117f 100644
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -125,7 +125,6 @@ static int do_spi_flash_probe(int argc, char * const argv[])
ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
if (!ret) {
device_remove(new);
- device_unbind(new);
}
flash = NULL;
ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] sf: fix sf probe
2016-08-17 7:19 [U-Boot] [PATCH] sf: fix sf probe Wenyou Yang
@ 2016-08-25 11:13 ` Stefan Roese
2016-09-12 8:13 ` Stefan Roese
2016-08-26 15:10 ` Hannes Schmelzer
2016-09-12 13:09 ` [U-Boot] " Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2016-08-25 11:13 UTC (permalink / raw)
To: u-boot
(Added Tom to Cc)
On 17.08.2016 09:19, Wenyou Yang wrote:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> This patch fixes the "sf probe" command. The very first SPI flash probe
> passes, for instance when u-boot tries to read its environment settings
> from a (Q)SPI memory but next "sf probe" commands fail because the flash
> memory node is unbound from the SPI controller children nodes.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Without this patch, "sf probe" fails miserably. So its definitely a
"must have" for this release.
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sf: fix sf probe
2016-08-25 11:13 ` Stefan Roese
@ 2016-09-12 8:13 ` Stefan Roese
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2016-09-12 8:13 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 25.08.2016 13:13, Stefan Roese wrote:
> (Added Tom to Cc)
>
> On 17.08.2016 09:19, Wenyou Yang wrote:
>> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>
>> This patch fixes the "sf probe" command. The very first SPI flash probe
>> passes, for instance when u-boot tries to read its environment settings
>> from a (Q)SPI memory but next "sf probe" commands fail because the flash
>> memory node is unbound from the SPI controller children nodes.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>
> Without this patch, "sf probe" fails miserably. So its definitely a
> "must have" for this release.
>
> Tested-by: Stefan Roese <sr@denx.de>
Tom, could you please include this patch in this release? Without it
DM based "sf probe" just fails. At least in my tests.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sf: fix sf probe
2016-08-17 7:19 [U-Boot] [PATCH] sf: fix sf probe Wenyou Yang
2016-08-25 11:13 ` Stefan Roese
@ 2016-08-26 15:10 ` Hannes Schmelzer
2016-09-06 1:03 ` Simon Glass
2016-09-12 13:09 ` [U-Boot] " Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Hannes Schmelzer @ 2016-08-26 15:10 UTC (permalink / raw)
To: u-boot
mfG
Schmelzer Hannes
On 08/17/2016 09:19 AM, Wenyou Yang wrote:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> This patch fixes the "sf probe" command. The very first SPI flash probe
> passes, for instance when u-boot tries to read its environment settings
> from a (Q)SPI memory but next "sf probe" commands fail because the flash
> memory node is unbound from the SPI controller children nodes.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> cmd/sf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/cmd/sf.c b/cmd/sf.c
> index 286906c..65b117f 100644
> --- a/cmd/sf.c
> +++ b/cmd/sf.c
> @@ -125,7 +125,6 @@ static int do_spi_flash_probe(int argc, char * const argv[])
> ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
> if (!ret) {
> device_remove(new);
> - device_unbind(new);
> }
> flash = NULL;
> ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] sf: fix sf probe
2016-08-26 15:10 ` Hannes Schmelzer
@ 2016-09-06 1:03 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2016-09-06 1:03 UTC (permalink / raw)
To: u-boot
On 26 August 2016 at 09:10, Hannes Schmelzer <hannes@schmelzer.or.at> wrote:
>
> mfG
> Schmelzer Hannes
>
> On 08/17/2016 09:19 AM, Wenyou Yang wrote:
>>
>> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>
>> This patch fixes the "sf probe" command. The very first SPI flash probe
>> passes, for instance when u-boot tries to read its environment settings
>> from a (Q)SPI memory but next "sf probe" commands fail because the flash
>> memory node is unbound from the SPI controller children nodes.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>> ---
>>
>> cmd/sf.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/cmd/sf.c b/cmd/sf.c
>> index 286906c..65b117f 100644
>> --- a/cmd/sf.c
>> +++ b/cmd/sf.c
>> @@ -125,7 +125,6 @@ static int do_spi_flash_probe(int argc, char * const
>> argv[])
>> ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
>> if (!ret) {
>> device_remove(new);
>> - device_unbind(new);
>> }
>> flash = NULL;
>> ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
>
> Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
>
Reviewed-by: Simon Glass <sjg@chromium.org>
The original code was to handle 'sf probe' where it actually creates a
new ad-hoc device (not from the device tree). But I'm happy to drop
this.
- Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] sf: fix sf probe
2016-08-17 7:19 [U-Boot] [PATCH] sf: fix sf probe Wenyou Yang
2016-08-25 11:13 ` Stefan Roese
2016-08-26 15:10 ` Hannes Schmelzer
@ 2016-09-12 13:09 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2016-09-12 13:09 UTC (permalink / raw)
To: u-boot
On Wed, Aug 17, 2016 at 03:19:39PM +0800, Wenyou Yang wrote:
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>
> This patch fixes the "sf probe" command. The very first SPI flash probe
> passes, for instance when u-boot tries to read its environment settings
> from a (Q)SPI memory but next "sf probe" commands fail because the flash
> memory node is unbound from the SPI controller children nodes.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Tested-by: Stefan Roese <sr@denx.de>
> Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160912/997d1150/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-12 13:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 7:19 [U-Boot] [PATCH] sf: fix sf probe Wenyou Yang
2016-08-25 11:13 ` Stefan Roese
2016-09-12 8:13 ` Stefan Roese
2016-08-26 15:10 ` Hannes Schmelzer
2016-09-06 1:03 ` Simon Glass
2016-09-12 13:09 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox