From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Schmelzer Date: Wed, 31 Aug 2016 19:45:28 +0200 Subject: [U-Boot] [PATCH v4 01/10] Kconfig: Separate AM33XX SOC config from target board config In-Reply-To: References: <20160830190629.13956-1-afd@ti.com> <20160830190629.13956-2-afd@ti.com> <57C7008B.6080900@schmelzer.or.at> Message-ID: <57C717B8.2010105@schmelzer.or.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de mfG Schmelzer Hannes On 08/31/2016 06:16 PM, Andrew F. Davis wrote: > On 08/31/2016 11:06 AM, Hannes Schmelzer wrote: >> On 08/30/2016 09:06 PM, Andrew F. Davis wrote: >>> The config option AM33XX is used in several boards and should be >>> defined as a stand-alone option for this SOC. We break this out >>> from target boards that use this SoC and common headers then enable >>> AM33XX on in all the boards that used these targets to eliminate any >>> functional change with this patch. >>> >>> This is similar to what has already been done in >>> 9de852642cae ("arm: Kconfig: Add support for AM43xx SoC specific >>> Kconfig") >>> and is done for the same reasons. >>> >>> Signed-off-by: Andrew F. Davis >>> --- >>> arch/arm/Kconfig | 98 >>> ++++-------------------------- >>> arch/arm/cpu/armv7/am33xx/Kconfig | 86 >>> ++++++++++++++++++++++++++ >>> configs/am335x_baltos_defconfig | 1 + >>> configs/am335x_boneblack_defconfig | 1 + >>> configs/am335x_boneblack_vboot_defconfig | 1 + >>> configs/am335x_evm_defconfig | 1 + >>> configs/am335x_evm_nor_defconfig | 1 + >>> configs/am335x_evm_norboot_defconfig | 1 + >>> configs/am335x_evm_spiboot_defconfig | 1 + >>> configs/am335x_evm_usbspl_defconfig | 1 + >>> configs/am335x_igep0033_defconfig | 1 + >>> configs/am335x_shc_defconfig | 1 + >>> configs/am335x_shc_ict_defconfig | 1 + >>> configs/am335x_shc_netboot_defconfig | 1 + >>> configs/am335x_shc_prompt_defconfig | 1 + >>> configs/am335x_shc_sdboot_defconfig | 1 + >>> configs/am335x_shc_sdboot_prompt_defconfig | 1 + >>> configs/am335x_sl50_defconfig | 1 + >>> configs/birdland_bav335a_defconfig | 1 + >>> configs/birdland_bav335b_defconfig | 1 + >>> configs/cm_t335_defconfig | 1 + >>> configs/pcm051_rev1_defconfig | 1 + >>> configs/pcm051_rev3_defconfig | 1 + >>> configs/pengwyn_defconfig | 1 + >>> configs/pepper_defconfig | 1 + >>> include/configs/ti_am335x_common.h | 1 - >>> 26 files changed, 120 insertions(+), 88 deletions(-) >> Hi Andrew, >> >> why is this "CONFIG_AM33XX" only done at related ti_am335x_common.h boards? >> >> grep -r "#define CONFIG_AM33XX" * >> include/configs/bur_am335x_common.h:#define CONFIG_AM33XX >> include/configs/ti_am335x_common.h:#define CONFIG_AM33XX >> include/configs/siemens-am33x-common.h:#define CONFIG_AM33XX >> >> I'm responsible for the bur_am335x_common.h related boards. >> > My original intent was to start with just one board (am335x_evm), but it > has a common header config with all these other boards, so they were > converted too for consistency. > > You should be able to convert your boards in a similar way and add them > to arch/arm/cpu/armv7/am33xx/Kconfig, or if you would like I can do that > for you in a different patch ( I don't want to add too much to this one, > it is already tested and I'm afraid to touch it to much :) ). > > Thanks, > Andrew OK for me. I will convert my boards later, once your series got applied. thanks, Hannes