public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/4] board: evb-rk3399: add api to support dwc3 gadget
Date: Thu, 01 Sep 2016 10:21:28 +0800	[thread overview]
Message-ID: <57C790A8.9070706@rock-chips.com> (raw)
In-Reply-To: <3bae92de-7c1c-e1c0-4ec0-2eea0bc99b7f@denx.de>

Hi Marek,

On 08/31/2016 08:30 PM, Marek Vasut wrote:
> On 08/31/2016 10:40 AM, Kever Yang wrote:
>> This patch add board_usb_init() and interrupt callback
>> for dwc3 gadget.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v3:
>> - remove utmi width DT parse from borad init
> OK
>
>> Changes in v2:
>> - parse dt for utmi width
>>
>>   board/rockchip/evb_rk3399/evb-rk3399.c | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
>> index d394276..0d39902 100644
>> --- a/board/rockchip/evb_rk3399/evb-rk3399.c
>> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c
>> @@ -7,6 +7,8 @@
>>   #include <dm.h>
>>   #include <dm/pinctrl.h>
>>   #include <asm/arch/periph.h>
>> +#include <usb.h>
>> +#include <dwc3-uboot.h>
>>   
>>   DECLARE_GLOBAL_DATA_PTR;
>>   
>> @@ -54,3 +56,24 @@ void dram_init_banksize(void)
>>   	gd->bd->bi_dram[0].start = 0x200000;
>>   	gd->bd->bi_dram[0].size = 0x80000000;
>>   }
>> +
>> +#ifdef CONFIG_USB_DWC3
>> +static struct dwc3_device dwc3_device_data = {
>> +	.maximum_speed = USB_SPEED_HIGH,
>> +	.base = 0xfe800000,
>> +	.dr_mode = USB_DR_MODE_PERIPHERAL,
>> +	.index = 0,
>> +	.dis_u2_susphy_quirk = 1,
>> +};
> Uh, didn't I complain last time that this should come from DT
> and not platdata ?

Since I'm not able to remove the platdata, I thought maybe I can init those
features here, I will parse DT for maximum_speed, base, and 
dis_u2_susphy_quirk
in next version.

Thanks,
- Kever
>> +int usb_gadget_handle_interrupts(void)
>> +{
>> +	dwc3_uboot_handle_interrupt(0);
>> +	return 0;
>> +}
>> +
>> +int board_usb_init(int index, enum usb_init_type init)
>> +{
>> +	return dwc3_uboot_init(&dwc3_device_data);
>> +}
>> +#endif
>>
>

  reply	other threads:[~2016-09-01  2:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31  8:39 [U-Boot] [PATCH v3 0/4] rk3399: enable dwc3 gadget and fastboot Kever Yang
2016-08-31  8:39 ` [U-Boot] [PATCH v3 1/4] rk3399: add a empty "sys_proto.h" header file Kever Yang
2016-08-31  8:40 ` [U-Boot] [PATCH v3 2/4] board: evb-rk3399: add api to support dwc3 gadget Kever Yang
2016-08-31 12:30   ` Marek Vasut
2016-09-01  2:21     ` Kever Yang [this message]
2016-09-01  8:58       ` Marek Vasut
2016-09-02  9:50         ` Kever Yang
2016-09-02 12:10           ` Marek Vasut
2016-08-31  8:40 ` [U-Boot] [PATCH v3 3/4] usb: dwc3: add support for 16 bit UTMI+ interface Kever Yang
2016-08-31 12:32   ` Marek Vasut
2016-09-01  2:22     ` Kever Yang
2016-08-31  8:40 ` [U-Boot] [PATCH v3 4/4] config: rk3399: add support for dwc3 gadget Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C790A8.9070706@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox