From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations
Date: Wed, 14 Sep 2016 06:22:27 +0200 [thread overview]
Message-ID: <57D8D083.3060901@denx.de> (raw)
In-Reply-To: <20160914034905.28795-1-Peter.Chubb@data61.csiro.au>
Hello Peter,
Am 14.09.2016 um 05:49 schrieb Peter.Chubb at data61.csiro.au:
> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed. This is unnecessary
> and annoying. Unnecessary, because
> the network driver should already have fliushed the cache for the DMAed area,
> and annoying because it generates a cache misalignment message.
>
> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
> ---
> cmd/net.c | 3 ---
> 1 file changed, 3 deletions(-)
I posted a fix for this here:
http://patchwork.ozlabs.org/patch/663489/
but I did not remove the flush operation ... can we really remove it?
If so, you can add my
Acked-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> Index: u-boot/cmd/net.c
> ===================================================================
> --- u-boot.orig/cmd/net.c 2016-09-07 13:50:46.616156851 +1000
> +++ u-boot/cmd/net.c 2016-09-07 19:18:18.962450874 +1000
> @@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p
> return CMD_RET_SUCCESS;
> }
>
> - /* flush cache */
> - flush_cache(load_addr, size);
> -
> bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
>
> rcode = bootm_maybe_autostart(cmdtp, argv[0]);
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-09-14 4:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 3:49 [U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations Peter.Chubb at data61.csiro.au
2016-09-14 4:22 ` Heiko Schocher [this message]
2016-09-14 4:48 ` Peter.Chubb at data61.csiro.au
2016-09-23 20:53 ` Joe Hershberger
2016-10-06 0:14 ` [U-Boot] [U-Boot, " Tom Rini
2016-10-11 20:50 ` Joe Hershberger
2016-10-13 17:39 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D8D083.3060901@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox