From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 14 Sep 2016 06:22:27 +0200 Subject: [U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations In-Reply-To: <20160914034905.28795-1-Peter.Chubb@data61.csiro.au> References: <20160914034905.28795-1-Peter.Chubb@data61.csiro.au> Message-ID: <57D8D083.3060901@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Peter, Am 14.09.2016 um 05:49 schrieb Peter.Chubb at data61.csiro.au: > After any operation that downloads a file (e.g., pxe get, or dhcp), the > buffer containing the downloaded data is flushed. This is unnecessary > and annoying. Unnecessary, because > the network driver should already have fliushed the cache for the DMAed area, > and annoying because it generates a cache misalignment message. > > Signed-off-by: Peter Chubb > --- > cmd/net.c | 3 --- > 1 file changed, 3 deletions(-) I posted a fix for this here: http://patchwork.ozlabs.org/patch/663489/ but I did not remove the flush operation ... can we really remove it? If so, you can add my Acked-by: Heiko Schocher bye, Heiko > > Index: u-boot/cmd/net.c > =================================================================== > --- u-boot.orig/cmd/net.c 2016-09-07 13:50:46.616156851 +1000 > +++ u-boot/cmd/net.c 2016-09-07 19:18:18.962450874 +1000 > @@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p > return CMD_RET_SUCCESS; > } > > - /* flush cache */ > - flush_cache(load_addr, size); > - > bootstage_mark(BOOTSTAGE_ID_NET_LOADED); > > rcode = bootm_maybe_autostart(cmdtp, argv[0]); > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany