From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Looijmans Date: Thu, 15 Sep 2016 09:41:00 +0200 Subject: [U-Boot] [PATCH 0/2] Add TOPIC Miami boards In-Reply-To: References: <1473919370-3717-1-git-send-email-mike.looijmans@topic.nl> Message-ID: <57DA508C.8070704@topic.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de ?On 15-09-16 08:54, Michal Simek wrote: > Hi Mike, > > On 15.9.2016 08:02, Mike Looijmans wrote: >> These patches add support for the Miami range of boards from TOPIC. >> The boards are based on Xilinx Zynq SoCs, these two patches are for >> the 7-series, the Ultrascale MPSOC boards are to be added later. >> >> Please note that the "ps7_init_gpl" files are largely generated by a >> tool and as a result of that, contain many style issues. >> >> Mike Looijmans (2): >> Add topic-miami board support >> Add topic_miamiplus board >> >> arch/arm/dts/Makefile | 2 + >> arch/arm/dts/zynq-topic-miami.dts | 98 + >> arch/arm/dts/zynq-topic-miamiplus.dts | 22 + >> board/xilinx/zynq/zynq-topic-miami/ps7_init_gpl.c | 4324 +++++++++++++++++++ >> board/xilinx/zynq/zynq-topic-miami/ps7_init_gpl.h | 118 + >> .../zynq/zynq-topic-miamiplus/ps7_init_gpl.c | 4425 ++++++++++++++++++++ >> .../zynq/zynq-topic-miamiplus/ps7_init_gpl.h | 150 + >> configs/topic_miami_defconfig | 47 + >> configs/topic_miamiplus_defconfig | 47 + >> include/configs/topic_miami.h | 147 + >> include/configs/topic_miamiplus.h | 2 + >> 11 files changed, 9382 insertions(+) >> create mode 100644 arch/arm/dts/zynq-topic-miami.dts >> create mode 100644 arch/arm/dts/zynq-topic-miamiplus.dts >> create mode 100644 board/xilinx/zynq/zynq-topic-miami/ps7_init_gpl.c >> create mode 100644 board/xilinx/zynq/zynq-topic-miami/ps7_init_gpl.h >> create mode 100644 board/xilinx/zynq/zynq-topic-miamiplus/ps7_init_gpl.c >> create mode 100644 board/xilinx/zynq/zynq-topic-miamiplus/ps7_init_gpl.h >> create mode 100644 configs/topic_miami_defconfig >> create mode 100644 configs/topic_miamiplus_defconfig >> create mode 100644 include/configs/topic_miami.h >> create mode 100644 include/configs/topic_miamiplus.h >> > > It is a question if this should go to board/xilinx folder. > I think you should create own folder just for your company. > Probably doesn't make sense to copy all Makefiles and so but I think > you can source them from Xilinx folder to be only at one location. I think a "topic" folder would be better, if I can avoid duplicating stuff. It'd also solve the merge conflict between the u-boot-xlnx tree and mainline, which have different makefiles. > The next thing is that there needs to be additional steps to fix > ps7_init_gpl.* files to keep checkpatch happy. > I have created change request to fix this directly in tools but still > none has fixed it and the team which is responsible for it is keep > moving to the next release but I can do nothing with it. A bit of scripting would take care of most of the problems I guess. Just removing all those C++ comment lines would be a good start. Currently I just include zynq-common.h and then have to #undef a lot of things. Maybe I'd better just copy the relevant parts and avoid using zynq-common.h. The alternative would be to make zynq-common more common and less specific to the evaluation boards. Mike. Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans at topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail Topic zoekt gedreven (embedded) software specialisten! http://topic.nl/vacancy/topic-zoekt-technische-software-engineers/